Port-i386 archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: source location of x86_cpu_topology()

David Laight <david%l8s.co.uk@localhost> wrote:
> A few years and and for some reason I really don't understand
> the function x86_cpu_topology() was moved out of x86/x86/identcpu.c
> into its own file.
> This really doean't make sense as the equivalent code for
> all the older processors (cpu_probe_xxx() functions is
> in identcpu.c
> Was there any real justification for this?
> It isn't as though the files are large.

I prefer to have that logic in a separate module.

If you are thinking of cpuctl - I think CPU topology structure and
logic should be abstracted in MI and have a MI interface.  I had some
patches for that.. by now ancient, though.


Home | Main Index | Thread Index | Old Index