Re: Volunteer for "Add FFS support to U-Boot"

[Jared McNeill <jmcneill%invisible.ca@localhost>]

Super cool! A few comments:

- Some of the global symbols in ffs_common.c ought to be removed and/or prefixed with “ffs_”. Do we really need custom alloc/dealloc and twiddle for example?
- I don’t think we need separate package options for cmd_ffs and fs_ufs. I think a “ufs” option that turns on CONFIG_CMD_UFS and CONFIG_FS_UFS, and a separate “ufs-write” option that turns on CONFIG_FS_UFS_WRITE is a simpler approach.
- The “ufs” option should be added to PKG_DEFAULT_OPTIONS not in each package’s Makefile, but in u-boot.mk. Currently the pkg options stuff is setup in u-boot-arm64.mk, this needs to be moved as well.

Keep up the good work!

Jared


> On Feb 22, 2018, at 4:12 PM, berte <behzaterte%yandex.com@localhost> wrote:
> 
> Hi folks,
> 
> You can find my patch as an attachment.
> 
> As I mentioned before, I still not sure about DEV_STRATEGY and alignment also u-boot fstype_info->probe missing. I'll investigate and clarify asap.
> 
> Any idea/suggestion/feedback would be more than welcome :-)
> 
> 
> Task Status: 
>    Add an ffs driver to U-Boot (read-only) -> done, but some open points exists
>    Add the following commands to U-Boot: ffssize, ffsload, ffsls -> done
>    Integrate changes with existing U-Boot packages (sysutils/u-boot*) in pkgsrc ->done
> 
>    Update armv7.img to support booting directly from FFS. -> wip
>    Modify sysinst to allow for installation without an MSDOS partition. -> tba
>        Some of this will be SoC-specific. Need to detect the SoC type and select the correct kernel/dtb and adjust partition layout to not interfere with U-Boot / SoC specific bootloaders.
> 
> 
> 
> 20.02.2018, 16:07, "berte" <behzaterte%yandex.com@localhost>:
>> Hey folks,
>> 
>> I've another tag for this task -> version_check_part01 but it's little bit premature.
>> 
>> Please give me your feedbacks/feelings.
>> 
>> 20.02.2018, 11:38, "berte" <behzaterte%yandex.com@localhost>:
>>>  Hi Martin,
>>> 
>>>  At the moment I'm changing source with using magic numbers, thanks for your support/advice :-)
>>> 
>>>  20.02.2018, 11:27, "Martin Husemann" <martin%duskware.de@localhost>:
>>>>   On Tue, Feb 20, 2018 at 12:02:57AM +0300, berte wrote:
>>>>>    Some modifications are done and pushed ufs_taks01_02_part1_done tag.
>>>>> 
>>>>>    Jared, I added +1 argument into uboot_cmd which is type argument and
>>>>>    it'll define filesystem types such as ffsv1,ffsv2, lfs, etc.(but I've
>>>>>    to need some know-how for u-boot stuff)
>>>> 
>>>>   I wouldn't do that - the supberblock easily tells you what type it is,
>>>>   don't bother the user with it.
>>>> 
>>>>   Martin
>>> 
>>>  --
>>>  Cheers,
>>>  --berte.
>> 
>> --
>> Cheers,
>> --berte.
> 
> -- 
> Cheers,
> --berte.
> <FFS_support_patch>