Re: Heads up: new SD controller driver for Raspberry Pi in -current

[Harold Gutch <logix%foobar.franken.de@localhost>]

Hi,

On Wed, Aug 16, 2017 at 05:54:53PM -0300, Jared McNeill wrote:
> On Wed, 16 Aug 2017, Harold Gutch wrote:
> 
> >On my Raspberry Pi 1 B+ V1.2 I get these errors with a RPI_INSTALL kernel
> >from head as of 2017-08-14 ~09:00 UTC:
> >
> >sdmmc0 at sdhost0
> >sdmmc0: sdmmc_mem_enable failed with error 5
> >sdmmc0: couldn't enable card: 5
> 
> Hi Harold --
> 
> I just committed a fix for this. Can you update your source tree and try 
> again?

My mirror didn't have your commit yet so I applied the two changes in
your commit manually, with those I now have ld0 again:

sdhc0: SDHC 3.0, rev 153, platform DMA, 250000 kHz, HS 3.3V, re-tuning mode 1, 1024 byte blocks
sdmmc0 at sdhc0 slot 0
sdmmc0: SD card status: 4-bit, C4
ld0 at sdmmc0: <0x03:0x5344:SU04G:0x80:0x22d64220:0x10b>
ld0: 3781 MB, 1920 cyl, 64 head, 63 sec, 512 bytes/sect x 7744512 sectors
ld0: 7592960 trailing sectors not covered by disklabel
ld0: 4-bit width, High-Speed/SDR25, 50.000 MHz

... and for the sake of completeness, it still works on my Raspberry
Pi 3 (this is with an earmv6hf RPI2_INSTALL):

sdmmc0 at sdhost0
sdmmc0: SD card status: 4-bit, C4
ld0 at sdmmc0: <0x03:0x5344:SU04G:0x80:0x22d64220:0x10b>
ld0: 3781 MB, 1920 cyl, 64 head, 63 sec, 512 bytes/sect x 7744512 sectors
ld0: 7592960 trailing sectors not covered by disklabel
ld0: 4-bit width, High-Speed/SDR25, 50.000 MHz
ld0: 7592960 trailing sectors not covered by disklabel

Out of curiosity, your fix basically hardcodes disabling sdhost on
the Pi 3 and the Zero W - is it not possible to instead probe for the
controller supported by sdhost?  Or if that exists on all Raspberries,
probe all sdmmc-devices for an SD card, a Pi 3 would then find ld0 on
sdmmc0 while in this scenario a Pi 1's dmesg output would look
something like this:

sdmmc0 at sdhost0
[ and nothing more then, nothing on sdmmc0 ]
sdmmc1 at sdhc0
ld0 at sdmmc1
[...]


Thanks a lot for the quick fix!
  Harold