Port-amd64 archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: cleaning up NMI handling in trap()

On Fri, Mar 18, 2011 at 03:27:00PM -0500, David Young wrote:
> Today I noticed that in trap() on amd64 and i386, the code for handling
> NMI is a rat's nest of #ifdefs.  I've tried to clean it up by adding
> some weak stub implementations for DDB and KGDB and letting the linker
> instead of the preprocessor configure the kernel.  Please have a look at
> the attached patch.  I'd like to commit something like it pretty soon.

I don't know much about this section, but I very much welcome the idea of
cleaning the preprocessor defines from the x86 MD code. Some sections are
nearly incomprehensible due to the rabid use of #ifdefs, the primary
offender being Xen.

- Jukka.

Home | Main Index | Thread Index | Old Index