Re: profiling kernel fails with: Error: suffix or operands invalid for `pushf'

[Makoto Fujiwara <makoto%ki.nu@localhost>]

| To: port-amd64%NetBSD.org@localhost
| From: Makoto Fujiwara <makoto%ki.nu@localhost>
| Date: Wed, 05 Dec 2007 17:55:58 +0900

mef> /var/tmp//cciUwi3L.s:173: Error: suffix or operands invalid for `pushf'
mef> (etc.)

Is this the patch to apply ?

Index: sys/arch/amd64/include/profile.h
===================================================================
RCS file: /e/cvsync/cvsync/src/sys/arch/amd64/include/profile.h,v
retrieving revision 1.12
diff -u -r1.12 profile.h
--- sys/arch/amd64/include/profile.h    20 Dec 2007 23:46:12 -0000      1.12
+++ sys/arch/amd64/include/profile.h    15 Jan 2008 02:06:26 -0000
@@ -137,14 +137,14 @@
 {
        u_long  ef;
 
-       __asm volatile("pushfl; popl %0" : "=r" (ef));
+       __asm volatile("pushfq; popq %0" : "=r" (ef));
        return (ef);
 }
 
 static inline void
 mcount_write_psl(u_long ef)
 {
-       __asm volatile("pushl %0; popfl" : : "r" (ef));
+       __asm volatile("pushq %0; popfq" : : "r" (ef));
 }
 
 #endif /* XEN */

---
Makoto Fujiwara, 
Chiba, Japan, Narita Airport and Disneyland prefecture.