pkgsrc-WIP-changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

libxlsxwriter: Have minizip use non-64 IO functions



Module Name:	pkgsrc-wip
Committed By:	Sijmen J. Mulder <ik%sjmulder.nl@localhost>
Pushed By:	sjmulder
Date:		Mon Dec 10 22:01:26 2018 +0100
Changeset:	403ba4cb992a70cf6cc4c6deb8ec7e5c0ded5ab1

Modified Files:
	libxlsxwriter/Makefile
Removed Files:
	libxlsxwriter/TODO

Log Message:
libxlsxwriter: Have minizip use non-64 IO functions

Some platforms have fopen64() and friends but minizip assumes all
non-Apple platforms have them. The alternative is to adjust the check
with every platofrm we find but that seems fragile.

To see a diff of this commit:
https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pkgsrc-wip.git;a=commitdiff;h=403ba4cb992a70cf6cc4c6deb8ec7e5c0ded5ab1

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

diffstat:
 libxlsxwriter/Makefile | 2 ++
 libxlsxwriter/TODO     | 3 ---
 2 files changed, 2 insertions(+), 3 deletions(-)

diffs:
diff --git a/libxlsxwriter/Makefile b/libxlsxwriter/Makefile
index 5a00fa1204..16ec421db8 100644
--- a/libxlsxwriter/Makefile
+++ b/libxlsxwriter/Makefile
@@ -15,6 +15,8 @@ USE_LANGUAGES+=	c c++
 
 MAKE_FLAGS+=	V=1
 MAKE_FLAGS+=	INSTALL_DIR=${DESTDIR}${PREFIX}
+# prevent minizip from assuming fopen64 and friends exist
+CFLAGS+=	-DIOAPI_NO_64
 
 .include "../../devel/zlib/buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"
diff --git a/libxlsxwriter/TODO b/libxlsxwriter/TODO
deleted file mode 100644
index a04c60b112..0000000000
--- a/libxlsxwriter/TODO
+++ /dev/null
@@ -1,3 +0,0 @@
-- On NetBSD there are warnings about implicit declaration of fopen64, probably
-  a `|| defined(__NetBSD__)' in third_party/minizip/ioapi.h:53 needs to be
-  added.


Home | Main Index | Thread Index | Old Index