Re: emulators/wine build failure

[Paul Goyette <paul%whooppee.com@localhost>]

wiz, you seem to be the last person to touch wine's M<akefile.  Would
it be possible for you to include this patch from riastradh?


On Mon, 26 Oct 2026, Paul Goyette wrote:

> From riastradh...
>
> > > From: Paul Goyette <paul%whooppee.com@localhost>
> > > Date: Thu, 30 Jul 2026 16:40:53 -0700 (PDT)
> > >
> > > On host netbsd-11.99.6 (amd64)
> > >
> > > dlls/ntdll/unix/signal_x86_64.c: In function 'save_context':
> > > dlls/ntdll/unix/signal_x86_64.c:899:5: error: cannot convert to a pointer 
> > > type
> > >   899 |     if (FPU_sig(sigcontext))
> > >       |     ^~
> >
> > Please try applying the attached patch, which should work on all
> > versions of NetBSD unconditionally.
> >
> > For details and background, and why it's probably better to just apply
> > this patch than to attempt further changes to NetBSD, see
> >
> > PR kern/60539: XSAVE changes break ucontext userspace API
>
> The patch works. how do we get it committed?
>
> > https://gnats.NetBSD.org/60539
> --- wine-9.0/dlls/ntdll/unix/signal_x86_64.c.~1~	2024-01-16 
> 20:55:47.000000000 +0000
> +++ wine-9.0/dlls/ntdll/unix/signal_x86_64.c	2026-10-26 06:23:29.438210431 
> +0000
> @@ -203,7 +203,7 @@
> #define RSP_sig(context)    (*((unsigned 
> long*)&(context)->uc_mcontext.__gregs[_REG_URSP]))
> #define TRAP_sig(context)   ((context)->uc_mcontext.__gregs[_REG_TRAPNO])
> #define ERROR_sig(context)  ((context)->uc_mcontext.__gregs[_REG_ERR])
> -#define FPU_sig(context)    ((XMM_SAVE_AREA32 
> *)((context)->uc_mcontext.__fpregs))
> +#define FPU_sig(context)    ((XMM_SAVE_AREA32 
> *)(&(context)->uc_mcontext.__fpregs))
> #define XState_sig(context) NULL
>
> #elif defined (__APPLE__)
>
> +---------------------+--------------------------+----------------------+
> | Paul Goyette (.sig) | PGP Key fingerprint:     | E-mail addresses:    |
> | (Retired)           | 1B11 1849 721C 56C8 F63A | paul%whooppee.com@localhost    |
> | Software Developer  | 6E2E 05FD 15CE 9F2D 5102 | pgoyette%netbsd.org@localhost  |
> | & Network Engineer  |                          | pgoyette99%gmail.com@localhost |
> +---------------------+--------------------------+----------------------+

+---------------------+--------------------------+----------------------+
| Paul Goyette (.sig) | PGP Key fingerprint:     | E-mail addresses:    |
| (Retired)           | 1B11 1849 721C 56C8 F63A | paul%whooppee.com@localhost    |
| Software Developer  | 6E2E 05FD 15CE 9F2D 5102 | pgoyette%netbsd.org@localhost  |
| & Network Engineer  |                          | pgoyette99%gmail.com@localhost |
+---------------------+--------------------------+----------------------+