Re: webkit-gtk41 missing sqlite path

[Greg Troxel <gdt%lexort.com@localhost>]

Thomas Klausner <wiz%gatalith.at@localhost> writes:

>> Do you mean "webkit-gtk41 has no reason to use sqlite3"?
>
> No, I meant I don't see a reason this error should occur on NetBSD 10
> and not on -current.
>
> Makefile.common includes sqlite3/bl3.mk, it should be a full
> dependency.

OK - agreed.

>> > Makefile.common has an explicit section about this:
>> >
>> > # otherwise, libsqlite3.so from ${BUILDLINK_DIR} is hardcoded into some binaries
>> > CMAKE_CONFIGURE_ARGS+=          -DSQLite3_LIBRARY=${BUILDLINK_PREFIX.sqlite3}/lib/libsqlite3.so
>> >
>> > Where is your sqlite3 library?
>> 
>> It's in /usr/pkg/lib.  As I understand it, pkgsrc does not use base
>> sqlite at all.
>> 
>> The "otherwise" is puzzling; that's unconditional.
>
> The comment is supposed to mean: if this file is missing, the path to
> the wrong libsqlite3.so (in the buildlinkdir) is hardcoded into the
> binary.

Yes, but /usr/pkg/lib/libsqlite3.so is present in the filesystem and every
other program that uses it as a dep is fine.

  $ ls -l /usr/pkg/lib/libsqlite3.so*
  lrwxr-xr-x  1 root  wheel       20 Aug 10 21:42 /usr/pkg/lib/libsqlite3.so -> libsqlite3.so.3.53.4
  lrwxr-xr-x  1 root  wheel       20 Aug 10 21:42 /usr/pkg/lib/libsqlite3.so.0 -> libsqlite3.so.3.53.4
  -rwxr-xr-x  1 root  wheel  1641584 Aug 10 21:42 /usr/pkg/lib/libsqlite3.so.3.53.4

>> Are you saying it builds for you on current?
>
> Yes.

Are your builds, and the ones on shadow, done with PKG_DEVELOPER=yes?

> If the file is really there, check if sqlite3 is only a build
> dependency in your environment (and if so, find out why); if that's
> not it, perhaps a bug in pkg_install? Which version is installed?

The problem is that the webkit lib in the destdir has a reference to the
sqlite3.so lib (symlink) in the buildlink3 tree in the workdir.  The
package is never built because the bad-libs check fires.

Looking at the cmake cache file after the build, I see a vast number of
libs with paths to the bl3 symlink tree.  But somehow, those end up with
the right paths in the built library.  I don't understand how this is
supposed to work -- it's been clear that cmake goes looking for files
rather than trying to use them to build and deciding they are ok, and
that bl3 only partially works around this unwanted cmake behavior.
Beyond that, things are less clear to me :-(

I realized that I have CMAKE_GENERATOR set to ninja.   But that is not
odd and I suspect you do too.  I will try without that.