Re: samba

[mlh%goathill.org@localhost (MLH)]

Thomas Klausner wrote:
> On Fri, Mar 13, 2026 at 09:12:56AM +0100, MLH wrote:
> > I reported a bug with building samba (v1) recently. It has been building
> > fine
> > up until the changes referenced here on 2026-03-01. My last pkgsrc version
> > is samba-3.6.25nb50.
> > 
> > Now configure fails with:
> > checking for test routines... configure: error: cant find test code.
> > Aborting config
> > *** Error code 1
> > 
> > Why was that changed?
> 
> autoconf provides config.log files with details.
> 
> In work/samba-3.6.25/source3/config.log you'll find
> 
> In file included from conftest.c:445:
> ./../tests/trivial.c:4:1: error: return type defaults to 'int'
> [-Wimplicit-int]
>     4 | main()
>       | ^~~~
> 
> gcc 14 (imported a couple months ago into NetBSD-current) enables more
> warnings by default, and this is one of them.
> 
> The configure test needs to be fixed to have 'int' before main, or the

Thanks for the reply

I am afraid to jump into the middle of all of the changes to the configure 
file there. 

> package Makefile needs to disable the warning (adding
> -Wno-implicit-int to the CFLAGS).

Adding
CFLAGS+=  -Wno-implicit-int
breaks a bunch of stuff with the build 

doc/pkgsrc* 15.3.3.  Passing CFLAGS to GNU configure scripts
CPPFLAGS+=              -Wno-implicit-int
CONFIGURE_ARGS+=        CPPFLAGS=${CPPFLAGS:M*:Q}
has the same results as 
CFLAGS+=  -Wno-implicit-int

So what is the correct way to set that which doesn't break a bunch of other 
stuff?
 
> Probably you'll stumble over more similar problems, you can send a
> patch when you fixed them all :-)

:^)