Re: [PATCH] rlwrap: make python optional

[Jonathan Perkin <jperkin%pkgsrc.org@localhost>]

* On 2024-12-18 at 06:50 GMT, Paul W. Rankin wrote:

> So rlwrap is only a small utility and probably shouldn't depend on
> both Python and Perl. I think both of these dependencies are just for
> optional filter plugins.

Generally this seems ok.  Upstream clearly mark these as experimental so 
I think it's fine to not include them by default.

> +.if !empty(PKG_OPTIONS:Mpython)
> REPLACE_PYTHON+=	filters/*.py
> REPLACE_PYTHON+=	filters/dissect_prompt
> REPLACE_PYTHON+=	filters/handle_sigwinch
> REPLACE_PYTHON+=	filters/makefilter

If python isn't enabled I would ensure that these scripts aren't 
installed at all.  Installing broken scripts seems like the worst of all 
options.

> +
> +###
> +### python option
> +###
> +

That's just 5 pointless lines, I'd remove them completely.

> +.if !empty(PKG_OPTIONS:Mppython)

Typo, double-"p".

--
Jonathan Perkin                    pkgsrc.smartos.org
Open Source Complete Cloud   www.tritondatacenter.com