Re: Palemoon and dbus dependency

[Vitaly Shevtsov <shev.vt1984%gmail.com@localhost>]

Hello, Nia.

Sounds strange, because I have palemoon built with gtk2 and I don't
have either GConf or dbus:
Configure options

--enable-application=palemoon
--with-external-source-dir=/usr/pkgsrc/www/palemoon/work/pale-moon
PKG_CONFIG=/usr/pkgsrc/www/palemoon/work/.tools/bin/pkg-config CC=gcc
CXX=c++ --enable-default-toolkit=cairo-gtk2 MAKE=make --enable-av1
--enable-jxl --disable-dbus --enable-devtools --disable-gamepad
--disable-gconf --disable-necko-wifi --enable-optimize=-O2
--disable-precompiled-startupcache --disable-pulseaudio
--disable-tests --disable-updater --disable-webrtc --prefix=/usr/pkg
--with-branding=palemoon/branding/unofficial --with-pthreads
--with-system-bz2 --with-system-zlib

Maybe I missed something :)

On Wed, Oct 2, 2024 at 9:04 PM nia <nia%netbsd.org@localhost> wrote:
>
> On Wed, Oct 02, 2024 at 08:53:48PM +0500, Vitaly Shevtsov wrote:
> > Hello!
> >
> > When installing palemoon, it installs dbus despite it is disabled. And
> > the reason for this is that palemoon depends on devel/GConf which
> > depends on dbus unconditionally. I have made a simple patch to address
> > this issue. Could you please review it?
>
> I'm sorry, but the patch is wrong because palemoon requires GConf when
> compiled with gtk2.
>
> > --- Makefile.orig       2024-10-02 20:50:40.493651223 +0500
> > +++ Makefile    2024-10-02 19:24:27.958384590 +0500
> > @@ -150,7 +150,6 @@
> >  .  include "../../audio/alsa-lib/buildlink3.mk"
> >  .endif
> >  .include "../../mk/atomic64.mk"
> > -.include "../../devel/GConf/buildlink3.mk"
> >  .include "../../devel/zlib/buildlink3.mk"
> >  .include "../../graphics/hicolor-icon-theme/buildlink3.mk"
> >  .include "../../lang/python/batteries-included.mk"
> > --- options.mk.orig     2024-10-02 20:50:58.181524919 +0500
> > +++ options.mk  2024-10-02 20:49:44.609108782 +0500
> > @@ -8,8 +8,10 @@
> >  .if !empty(PKG_OPTIONS:Mdbus)
> >  CONFIGURE_ARGS+=       --enable-dbus
> >  .  include "../../sysutils/dbus/buildlink3.mk"
> > +.  include "../../devel/GConf/buildlink3.mk"
> >  .else
> >  CONFIGURE_ARGS+=       --disable-dbus
> > +CONFIGURE_ARGS+=    --disable-gconf
> >  .endif
> >
> >  .if !empty(PKG_OPTIONS:Mpulseaudio)