Re: devel/extra-cmake-modules

[Thomas Klausner <wiz%NetBSD.org@localhost>]

On Fri, Jan 28, 2022 at 12:12:25PM +0800, Kinoshita Daisuke wrote:
> The package devel/extra-cmake-modules has a
> file "find-modules/FindPythonModuleGeneration.cmake", and there
> is a following statement in the file.
> 
> ----------------------------------------------------------------------
> if (NOT GPB_PYTHON3_LIBRARY)
>   set(_PYTHON3_MIN_VERSION 4)
>   set(_PYTHON3_MAX_VERSION 10)
> 
>   _find_python(3 ${_PYTHON3_MAX_VERSION}) # Canary check
> 
>   if (GPB_PYTHON3_LIBRARY)
>     message(FATAL_ERROR "The max python version in
> ${CMAKE_FIND_PACKAGE_NAME} must be updated.")
>   endif()
> ----------------------------------------------------------------------
> 
> For Python 3.9 or earlier, it works fine. But, for Python 3.10,
> it prevents some other packages being built successfully.
> 
> Is it a good idea to give a modification like below? Or, any
> other better way?
> 
> patches/patch-find-modules_FindPythonModuleGeneration.cmake
> ----------------------------------------------------------------------
> $NetBSD$
> 
> --- find-modules/FindPythonModuleGeneration.cmake.orig    2021-03-31
> 09:41:40.000000000 +0000
> +++ find-modules/FindPythonModuleGeneration.cmake
> @@ -165,7 +165,7 @@ endif()
> 
>  if (NOT GPB_PYTHON3_LIBRARY)
>    set(_PYTHON3_MIN_VERSION 4)
> -  set(_PYTHON3_MAX_VERSION 10)
> +  set(_PYTHON3_MAX_VERSION 99)
> 
>    _find_python(3 ${_PYTHON3_MAX_VERSION}) # Canary check
> 
> ----------------------------------------------------------------------

I've updated the package and added this patch.
Can you please report this issue upstream?

Thanks for your reports!
 Thomas