Re: devel/nss build failure on aarch64

[Thomas Klausner <wiz%NetBSD.org@localhost>]

On Sun, Aug 29, 2021 at 04:09:44PM +0000, Benny Siegert wrote:
> I am trying to update Firefox on my Pinebook Pro running NetBSD 9 aarch64,
> and I am getting the following error during "make replace" of devel/nss:

mrg recently committed a patch for this arch to nss. Do you have this
in your CVS tree?
 Thomas

--- Begin Message ---

• To: pkgsrc-changes%NetBSD.org@localhost
• Subject: CVS commit: pkgsrc/devel/nss/patches
• From: "matthew green" <mrg%netbsd.org@localhost>
• Date: Fri, 27 Aug 2021 21:33:18 +0000

Module Name:	pkgsrc
Committed By:	mrg
Date:		Fri Aug 27 21:33:18 UTC 2021

Added Files:
	pkgsrc/devel/nss/patches: patch-nss_lib_freebl_sha256-armv8.c

Log Message:
fix build on arm64eb: sha512.c and sha256-armv8.c both provided the
same symbols.  (sha256-x86.c has the same problem, but that file
already requires little endian so is not a big deal.)


To generate a diff of this commit:
cvs rdiff -u -r0 -r1.1 \
    pkgsrc/devel/nss/patches/patch-nss_lib_freebl_sha256-armv8.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Added files:

Index: pkgsrc/devel/nss/patches/patch-nss_lib_freebl_sha256-armv8.c
diff -u /dev/null pkgsrc/devel/nss/patches/patch-nss_lib_freebl_sha256-armv8.c:1.1
--- /dev/null	Fri Aug 27 21:33:18 2021
+++ pkgsrc/devel/nss/patches/patch-nss_lib_freebl_sha256-armv8.c	Fri Aug 27 21:33:18 2021
@@ -0,0 +1,17 @@
+--- nss/lib/freebl/sha256-armv8.c.orig	2021-08-05 01:03:36.000000000 -0700
++++ nss/lib/freebl/sha256-armv8.c	2021-08-27 14:21:56.160037512 -0700
+@@ -2,7 +2,7 @@
+  * License, v. 2.0. If a copy of the MPL was not distributed with this
+  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
+ 
+-#ifdef USE_HW_SHA2
++#if defined(USE_HW_SHA2) && defined(IS_LITTLE_ENDIAN)
+ 
+ #ifndef __ARM_FEATURE_CRYPTO
+ #error "Compiler option is invalid"
+@@ -200,4 +200,4 @@ SHA256_Update_Native(SHA256Context *ctx,
+     }
+ }
+ 
+-#endif /* USE_HW_SHA2 */
++#endif /* USE_HW_SHA2 && IS_LITTLE_ENDIAN */

--- End Message ---