Re: games/xpipeman problem?

[Paul Goyette <paul%whooppee.com@localhost>]

Thanks for quick turn-around!


On Sat, 30 Jan 2021, Roland Illig wrote:

> On 30.01.2021 16:15, Paul Goyette wrote:
> > Not that I play often :) but xpipeman seems tobe broken.  Running
> > it seems to call abort(), ...
>
> Fixed.  It was a trivial buffer overflow that would have been caught if
> the CFLAGS had only included -Werror=format.
>
> To find the cause and fix it, I did this:
>
> cd games/xpipeman
> bmake configure
> bmake build-env
> make CFLAGS="-O0 -ggdb"
> ^D
> bmake install
> gdb --args work/xpipeman/xpipeman
> r
> where
>
> This told me that sprintf was called from main.c:324.  The rest was
> simple character counting.
>
> Roland
>
> !DSPAM:6015a97f296096962216590!

+--------------------+--------------------------+-----------------------+
| Paul Goyette       | PGP Key fingerprint:     | E-mail addresses:     |
| (Retired)          | FA29 0E3B 35AF E8AE 6651 | paul%whooppee.com@localhost     |
| Software Developer | 0786 F758 55DE 53BA 7731 | pgoyette%netbsd.org@localhost   |
+--------------------+--------------------------+-----------------------+