Re: Patch for editors/lyx

[Chavdar Ivanov <ci4ic4%gmail.com@localhost>]

On Sat, 22 Aug 2020 at 13:41, Connor McLaughlan <cont6pro3%gmail.com@localhost> wrote:
>
> Hi,
>
> i am using pkgsrc-2020Q2 and editors/lyx version 2.3.2 was not
> building on sparc64, but the problem is unrelated to the architecture.
>
> The error was a missing include:
>
> gmake[4]: Entering directory '/usr/pkgsrc/editors/lyx/work/lyx-2.3.2/src'
>   CHK      lyx_commit_hash.h
>   CXX      insets/ExternalTemplate.o
> insets/ExternalTemplate.cpp: In member function 'void
> lyx::external::Template::dumpFormats(std::ostream&) const':
> insets/ExternalTemplate.cpp:194:2: error: 'for_each' was not declared
> in this scope
>   for_each(formats.begin(), formats.end(), DumpFormat(os));
>   ^~~~~~~~
> [...]
> gmake[4]: *** [Makefile:2389: insets/ExternalTemplate.o] Error 1
> gmake[4]: Leaving directory '/usr/pkgsrc/editors/lyx/work/lyx-2.3.2/src'
> gmake[3]: *** [Makefile:2467: all-recursive] Error 1
>
>
> I have found an analysis and patch allowing me to build it again here:
> https://bugs.gentoo.org/730340
>
> diff --git a/src/insets/ExternalTemplate.cpp b/src/insets/ExternalTemplate.cpp
> index ae9148b..39a96ae 100644
> --- a/src/insets/ExternalTemplate.cpp
> +++ b/src/insets/ExternalTemplate.cpp
> @@ -22,6 +22,7 @@
>  #include "support/PathChanger.h"
>  #include "support/Translator.h"
>
> +#include <algorithm>

The present version in pkgsrc (lyx-2.3.5.2) already has this include.

>  #include <ostream>
>
>  using namespace std;
>
>
> Regards,
> Connor



-- 
----