Re: Failure to build misc/libreoffice - pdfium problems?

[Greg Oster <oster%netbsd.org@localhost>]

On Mon, 28 Oct 2019 23:35:59 +0900
Ryo ONODERA <ryo%tetera.org@localhost> wrote:

> Hi,
> 
> Paul Goyette <paul%whooppee.com@localhost> writes:
> 
> > On Mon, 28 Oct 2019, Chavdar Ivanov wrote:
> >  
> >> Just to mention - my last build - successful - was with
> >> X11_TYPE=native, java was also not disabled; this was under 9.99.17
> >> (amd64).  
> >
> > I have verifed that java does not matter - it fails in the same
> > manner whether java is enabled or disabled.
> >
> > I _do_ have 600+ other packages installed.  I can provide the list
> > of them if it will be useful.  
> 
> If I understand correctly, misc/libreoffice pdfium build with
> freetype 2.10.0 in xsrc of netbsd-8, netbsd-9 and HEAD should fail,
> because their ftobjs.c and freetype.h have the following signature
> for FT_Get_Name_Index().
> 
>   FT_EXPORT_DEF( FT_UInt )
>   FT_Get_Name_Index( FT_Face     face,
>                      FT_String*  glyph_name )
> 
> Freetype 2.10.1 has different signature.
> 
>   FT_EXPORT( FT_UInt )
>   FT_Get_Name_Index( FT_Face           face,
>                      const FT_String*  glyph_name );

Ah, yes!!  This is precisely the build problem I've been seeing on
netbsd-9 with native xsrc:
....
In file included
from /usr/pkgsrc/misc/libreoffice/work.thog/libreoffice-6.3.2.2 /workdir/UnpackedTarball/pdfium/third_party/freetype/src/src/base/ftbase.c:32:0:
/usr/pkgsrc/misc/libreoffice/work.thog/libreoffice-6.3.2.2/workdir/UnpackedTarball/pdfium/third_party/freetype/src/src/base/ftobjs.c:4062:3:
error: conflicting types for 'FT_Get_Name_Index'
   FT_Get_Name_Index( FT_Face     face,
   ^~~~~~~~~~~~~~~~~
....

Later...

Greg Oster

> My patch,
> pkgsrc/misc/libreoffice/patches/patch-external_pdfium_pkgsrc.patch.1
> has diffs to follow this change. However it will work only for
> pkgsrc/graphics/freetype2, not for freetype in xsrc.
> 
> I will try to remove pdfium's internal freetype as nros suggested
> later. I wish it was effective for our case...
> 
> > +--------------------+--------------------------+-----------------------+
> > | Paul Goyette       | PGP Key fingerprint:     | E-mail
> > addresses:     | | (Retired)          | FA29 0E3B 35AF E8AE 6651 |
> > paul%whooppee.com@localhost     | | Software Developer | 0786 F758 55DE 53BA
> > 7731 | pgoyette%netbsd.org@localhost   |
> > +--------------------+--------------------------+-----------------------+  
> 
> -- 
> Ryo ONODERA // ryo%tetera.org@localhost
> PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3