Re: Failure to build firefox

[Ryo ONODERA <ryo%tetera.org@localhost>]

Hi,

Your icu patch fix the failure of www/firefox build.

Thank you very much.

From: David Brownlee <abs%absd.org@localhost>, Date: Tue, 11 Dec 2018 10:21:24 +0000

> Try the latest icu - it *should* fix the firefox build issue (build still
> running here)
> 
> ---------- Forwarded message ---------
> From: David Brownlee <abs%netbsd.org@localhost>
> Date: Tue, 11 Dec 2018 at 10:15
> Subject: CVS commit: pkgsrc/textproc/icu
> To: <pkgsrc-changes%netbsd.org@localhost>
> 
> Module Name:    pkgsrc
> Committed By:   abs
> Date:           Tue Dec 11 10:15:56 UTC 2018
> 
> Modified Files:
>         pkgsrc/textproc/icu: Makefile distinfo
> Added Files:
>         pkgsrc/textproc/icu/patches: patch-common_unicode_urename.h
>             patch-i18n_uspoof.cpp
> 
> Log Message:
> Apply ICU-20208 uspoof.cpp function checkImpl should be static from
> https://github.com/unicode-org/icu/commit/8baff8f03e07d8e02304d0c888d0bb21ad2eeb01
> 
> This should fix the firefox build with this version of icu
> 
> Bump PKGREVISION
> 
> On Tue, 11 Dec 2018 at 09:58, David Brownlee <abs%absd.org@localhost> wrote:
>>
>> There is a fix for icu - just testing now before commit
>>
>> David
>> On Tue, 11 Dec 2018 at 09:46, Paul Goyette <paul%whooppee.com@localhost> wrote:
>> >
>> > With an up-to-date pkgsrc, and starting with a newly created sandbox
>> > (via sysutils/mksandbox), I am seeing the following errors:
>> >
>> > /tmp/pkgs/www/firefox/work.x86_64/firefox-63.0.3/js/src/wasm/AsmJS.cpp:
> In function 'bool js::CompileAsmJS(JSContext*, js::AsmJSParser&,
> js::frontend::ParseNode*, bool*)':
>> >
> /tmp/pkgs/www/firefox/work.x86_64/firefox-63.0.3/js/src/wasm/AsmJS.cpp:6750:76:
> warning: 'time' may be used uninitialized in this function
> [-Wmaybe-uninitialized]
>> >       return JS_smprintf("total compilation time %dms; %s", time,
> cacheString);
>> >
>      ^
>> >
> /tmp/pkgs/www/firefox/work.x86_64/firefox-63.0.3/js/src/wasm/AsmJS.cpp:6778:18:
> note: 'time' was declared here
>> >           unsigned time;
>> >                    ^~~~
>> >
>> >
>> >
>> >
> +------------------+--------------------------+----------------------------+
>> > | Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:
>    |
>> > | (Retired)        | FA29 0E3B 35AF E8AE 6651 | paul at whooppee dot
> com   |
>> > | Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd dot
> org |
>> >
> +------------------+--------------------------+----------------------------+

--
Ryo ONODERA // ryo%tetera.org@localhost
PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3