Re: graphics/libv4l

[Patrick Welche <prlw1%cam.ac.uk@localhost>]

On Mon, Sep 10, 2018 at 05:27:05PM +0100, Robert Swindells wrote:
> 
> Patrick Welche <prlw1%cam.ac.uk@localhost> wrote:
> >>On Mon, Sep 10, 2018 at 04:18:45PM +0100, Robert Swindells wrote:
> >>> 
> >>> Patrick Welche <prlw1%cam.ac.uk@localhost> wrote:
> >>> >On Sun, Sep 09, 2018 at 06:19:25PM +0100, Robert Swindells wrote:
> >>> >> I could use some ideas on how to check whether the NetBSD build host
> >>> >> has the new version of videoio.h
> >>> >
> >>> >How do they differ?
> >>> 
> >>> Old:
> >> 
> >> -rw-r--r--  1 rjs  staff  20927 Sep 17  2008 videoio.h
> >> 
> >> New:
> >> 
> >> -rw-rw-r--  1 rjs  staff  130935 Aug 25 23:41 videoio.h
> >> 
> >> The new one is copied from OpenBSD.
> >
> >The first #define in the OpenBSD one is V4L2_SEL_TGT_CROP, which doesn't
> >seem to exist in the NetBSD one. Would something like
> >
> >  #if defined(HAVE_VIDEOIO_H) && defined(V4L2_SEL_TGT_CROP)
> >
> >be good enough? Or what issue have you hit? (AC_EGREP_HEADER?)
> 
> I'm trying to work out what should go in the Makefile, the existing one
> copies headers from the files subdirectory to the build tree under
> certain conditions.

It looks as though that copy was added to allow compilation on NetBSD 4
which had no videoio.h. The copy won't happen if videoio.h exists.
AFAICT, if you update your system's videoio.h, libv4l should just use
it, so no Makefile tweaking should be necessary.

Do you observe something else? or have I missed the point again?

Cheers,

Patrick