Re: CVS commit: pkgsrc/security/openpam

[Frédéric Fauberteau <triaxx%NetBSD.org@localhost>]

Le 2018-05-15 09:57, Frédéric Fauberteau a écrit :
> Module Name:	pkgsrc
> Committed By:	triaxx
> Date:		Tue May 15 07:57:32 UTC 2018
>
> Modified Files:
> 	pkgsrc/security/openpam: Makefile PLIST builtin.mk distinfo
> 	pkgsrc/security/openpam/patches: patch-lib_libpam_openpam__constants.c
> Added Files:
> 	pkgsrc/security/openpam/patches: patch-doc_man_pam.conf.5
>
> Log Message:
> openpam: update to 20170430
>
> * patch-lib_libpam_openpam__constants.c:
>   * comment it (make pkglint happy)
>   * fix OPENPAM_MODULES_DIR (avoid openpam loading basesystem modules)

I am not sure about the right behavior:

Makefile:
--------------------------------------------------------------------------------
CONFIGURE_ARGS+=  --with-modules-dir=${PREFIX}/lib/security

work/openpam-20170430/lib/libpam/openpam_constants.c:
--------------------------------------------------------------------------------
#ifdef OPENPAM_MODULES_DIR
  OPENPAM_MODULES_DIR,
#else
  "/usr/lib",
  "/usr/local/lib",
#endif

FMO, it means either we use a specified module directory or we use the 
basesystem directories. Here, we declare a module directory but it did 
not work before I fix openpam_constants.c (it tested 
OPENPAM_MODULES_DIRECTORY). Modules from /usr/pkg/lib/security was not 
loaded. Now, it just works but supplementary modules provided by 
basesystem become not avaible. Should the following modifications be 
prefered?

#ifdef OPENPAM_MODULES_DIR
  OPENPAM_MODULES_DIR,
#endif
  "/usr/lib",
  "/usr/local/lib",