pkgsrc-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Build failure with vlc (pkgsrc-2018Q1) [with patch]



I have this build error of multimedia/vlc:

codec/x264.c: In function 'Open':
codec/x264.c:850:26: error: 'x264_bit_depth' undeclared (first use in this function)
         const int mask = x264_bit_depth > 8 ? X264_CSP_HIGH_DEPTH : 0;
                          ^
codec/x264.c:850:26: note: each undeclared identifier is reported only once for each function it appears in
Makefile:9088: recipe for target 'codec/libx264_plugin_la-x264.lo' failed
gmake[4]: *** [codec/libx264_plugin_la-x264.lo] Error 1
gmake[4]: *** Waiting for unfinished jobs....
gmake[4]: Leaving directory '/pkg_comp/obj/pkgsrc/multimedia/vlc/default/vlc-2.2.6/modules'

The offending code is guarded by #if X264_BUILD >= 118.
In my old install of include/x264.h (with X264_BUILD == 152) it seems
that it has
X264_API extern const int x264_bit_depth;
In the new one, used to build with, X264_BUILD is 155 and x264_bit_depth
is gone.

This additional patch file seems to make it build.
I have not tried running it yet.

patch-modules-codec-x264.c:

$NetBSD$

--- modules/codec/x264.c.orig	2015-04-13 19:54:35.000000000 +0000
+++ modules/codec/x264.c
@@ -843,7 +843,7 @@ static int  Open ( vlc_object_t *p_this 
     fullrange = var_GetBool( p_enc, SOUT_CFG_PREFIX "fullrange" );
     p_enc->fmt_in.i_codec = fullrange ? VLC_CODEC_J420 : VLC_CODEC_I420;
     p_sys->i_colorspace = X264_CSP_I420;
-#if X264_BUILD >= 118
+#if X264_BUILD >= 118 && X264_BUILD < 155
     char *psz_profile = var_GetString( p_enc, SOUT_CFG_PREFIX "profile" );
     if( psz_profile )
     {

-Olaf.
-- 
___ Olaf 'Rhialto' Seibert  -- Wayland: Those who don't understand X
\X/ rhialto/at/falu.nl      -- are condemned to reinvent it. Poorly.

Attachment: signature.asc
Description: PGP signature



Home | Main Index | Thread Index | Old Index