Re: 2017Q2 devel/libuv on Solaris 10 workaround

42  CFLAGS.SunOS+=  -D_XOPEN_SOURCE -D_XOPEN_SOURCE_EXTENDED=1

Specifically the first part -D_XOPEN_SOURCE : when I remove it, it works

I think I finally found the error in the work/http-2.4.27/config.log file:

configure:5459: gcc -o conftest -O2 -D__EXTENSIONS__ -D_XOPEN_SOURCE -D_XOPEN_SO

URCE_EXTENDED=1 -I/opt/pkg-2017Q2/include -I/usr/include -I/opt/pkg-2017Q2/inclu

de/apr-1 -I/opt/pkg-2017Q2/include/ncurses -I/opt/pkg-2017Q2/include -I/usr/incl

ude -I/opt/pkg-2017Q2/include/apr-1 -I/opt/pkg-2017Q2/include/ncurses -DSOLARIS2

=10 -D_POSIX_PTHREAD_SEMANTICS -D_REENTRANT -D_LARGEFILE64_SOURCE -L/opt/pkg-201

7Q2/gcc5/lib/gcc/i486-sun-solaris2.10/5.4.0 -Wl,-R/opt/pkg-2017Q2/gcc5/lib/gcc/i

486-sun-solaris2.10/5.4.0 -L/opt/pkg-2017Q2/gcc5/lib -Wl,-R/opt/pkg-2017Q2/gcc5/

lib -L/opt/pkg-2017Q2/lib -L/usr/lib -Wl,-R/usr/lib -Wl,-R/opt/pkg-2017Q2/lib co

nftest.c  >&5

In file included from /usr/include/stdio.h:21:0,

                 from conftest.c:9:

/opt/pkg-2017Q2/gcc5/lib/gcc/i486-sun-solaris2.10/5.4.0/include-fixed/sys/featur

e_tests.h:346:2: error: #error "Compiler or options invalid for pre-UNIX 03 X/Op

en applications         and pre-2001 POSIX applications"

 #error "Compiler or options invalid for pre-UNIX 03 X/Open applications \

^

configure:5463: $? = 1

configure:5470: ./conftest

./configure: line 5472: ./conftest: No such file or directory

configure:5474: $? = 127

Michel

On 7 Aug 2017, at 09:28, Jonathan Perkin <jperkin%joyent.com@localhost> wrote:

* On 2017-08-06 at 08:29 BST, Michel Jansens wrote:

Just adding the following line to devel/libuv/Makefile :
CFLAGS+=-DSUNOS_NO_IFADDRS

What do I need to do to have this included definitively in pksrc?
and where to best put this compile time definition to make it clean?

I've committed this to pkgsrc, thanks for the headsup:

http://mail-index.netbsd.org/pkgsrc-changes/2017/08/07/msg161059.html

* On 2017-08-07 at 06:54 BST, Jörn Clausen wrote:

See pkg/52245. The problem (I guess) is, that distinguishing Solaris
10 and 11 in pkgsrc is not easy, both are labelled "SunOS", together
with all the surviving descendants of OpenSolaris.

Get used to have a bunch of local fixes on Solaris. You can apply
fixes like this locally, I keep track of them with RCS. If you need to
fix the sources of a package, define LOCALPATCHES in mk.conf and keep
your own patches there. Do report these changes back to pkgsrc,
sometimes (well, often :) they are used. But for cases like this you
will need local workarounds.

There should be no need for this, we have OS_VERSION and
MACHINE_PLATFORM to identify SunOS releases, or if we want to do
things correctly we can always add feature tests.

* On 2017-08-07 at 06:54 BST, Michel Jansens wrote:

I managed to complete the build of www/apache24 on pkgsrc 2017Q2:

In Makefile, comment out all SunOS specifics:

#CFLAGS.SunOS+=-D__EXTENSIONS__
#.if !empty(CC_VERSION:Mgcc-[7-9]*)
#CFLAGS.SunOS+=-D_XOPEN_SOURCE=600
#.else
#CFLAGS.SunOS+=-D_XOPEN_SOURCE -D_XOPEN_SOURCE_EXTENDED=1
#.endif

Maybe this problem is because I’m building with gcc (with ABI=32)?

This will only break other platforms, could you let us know what
issues you are seeing with these flags and we'll try to find a fix
which works for everyone.

Thanks,

--
Jonathan Perkin - Joyent, Inc. - www.joyent.com