Re: foomatic fix

[Leonardo Taccari <leot%NetBSD.org@localhost>]

Emmanuel Dreyfus writes:
> Hello
> 

Hello Emmanuel,

> After upgrading foomatic-filters I have been hit by this error:
> Can't use 'defined(@array)' (Maybe you should just omit the defined()?) 
> at /usr/pkg/bin/foomatic-rip line 1477.
> 
> After looking for similar errors in other software, I tried
> this with success:
> --- /usr/pkg/bin/foomatic-rip.orig      2017-02-09 10:51:00.000000000 +0100
> +++ /usr/pkg/bin/foomatic-rip   2017-02-09 10:54:23.000000000 +0100
> @@ -1473,9 +1473,9 @@
>  ## default settings from the PPD file are valid and correct them
>  ## if nexessary.
>  
>  my $dontparse = 0;
> -if ((!defined(@{$dat->{'args'}})) ||
> +if ((!defined($dat->{'args'}) || !@{$dat->{'args'}}) ||
>      ($#{$dat->{'args'}} < 0)) {
>      # We don't have any options, so we do not need to parse the
>      # PostScript data
>      $dontparse = 1;
> 
> Should I commit this as a patch to the package?

Yes, please!


Thank you!