Re: [PATCH 1/1] Update audio/pavucontrol to 3.0

[coypu%SDF.ORG@localhost]

On Tue, Jan 26, 2016 at 03:30:55PM +0100, Thomas Klausner wrote:
> On Tue, Jan 26, 2016 at 02:24:54PM +0000, coypu wrote:
> > diff --git a/audio/pavucontrol/Makefile b/audio/pavucontrol/Makefile
> > index 21cb811..b7aff73 100644
> > --- a/audio/pavucontrol/Makefile
> > +++ b/audio/pavucontrol/Makefile
> > @@ -1,14 +1,16 @@
> >  # $NetBSD: Makefile,v 1.43 2015/11/03 19:10:07 joerg Exp $
> >  #
> >  
> > -DISTNAME=	pavucontrol-0.9.10
> > +DISTNAME=	pavucontrol-3.0
> >  PKGREVISION=	29
> 
> Please remove PKGREVISION lines when updating packages.
> 

Will do

> >  MAINTAINER=	pkgsrc-users%NetBSD.org@localhost
> > -HOMEPAGE=	http://0pointer.de/lennart/projects/pavucontrol/
> > +HOMEPAGE=	http://freedesktop.org/software/pulseaudio/pavucontrol/
> >  COMMENT=	Volume control tool ("mixer") for the PulseAudio sound server
> > +LICENSE=	gnu-gpl-v2
> > +EXTRACT_SUFX=	.tar.xz
> 
> EXTRACT_SUFX belongs to the bottom of the first section.
> 
> >  .include "../../x11/gtk2/buildlink3.mk"
> > -.include "../../x11/gtkmm/buildlink3.mk"
> > +.include "../../x11/gtkmm3/buildlink3.mk"
> 
> gtk2+gtkmm (v2) and gtkmm3, are you sure?
>  Thomas
Probably not. gtkmm3 is needed, unsure about gtk2.
I cannot test a clean build with no packages because audio/flac is failing.
cpu.c:480:6: error: expected ';' before 'volatile'
  asm volatile (".byte 0x0f, 0x01, 0xd0" : "=a"(lo), "=d"(hi) : "c"
  (0));
I need -ansi or so.

Thanks for reviewing