pkgsrc-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: new packages: freiOr and py-mlt

sergio de Almeida Lenzi <> writes:

> Index: Makefile
> ===================================================================
> RCS file: /cvsroot/pkgsrc/multimedia/mlt/Makefile,v
> retrieving revision 1.51
> diff -u -u -r1.51 Makefile
> --- Makefile	21 Feb 2015 23:35:41 -0000	1.51
> +++ Makefile	15 Mar 2015 02:33:33 -0000
> @@ -31,4 +31,10 @@
>  .include "../../x11/kdelibs4/"
>  .include "../../x11/qt4-libs/"
> +.if ${PKGPATH} != "multimedia/mlt"
> +.include	"../../lang/python27/"
> +.include	"../../lang/python/"
> +.include	"../../multimedia/mlt/"
> +.endif
> +
>  .include "../../mk/"

We don't do this sort of thing as it leads the package behaving
differently when built as a dependency vs straight.  Presumably what you
really need is python support?   In that case the thing to do is to
assess how many usages need it vs how much it costs (with kdelibs4
already there, python seems tiny to me :-( ), and whether to just enable
it or to make it an option.    Plus, I don't see why the python27 bl3 is
included; extension should be good enough (and allow the user to specify
version), and I also don't see why the package's own bl3 is included.

If you would like to put the other things in wip (where it's easier for
many others to review and try), just send me your sourceforge username
and I'll put you on the acl.

Attachment: pgpOTXNNos3oP.pgp
Description: PGP signature

Home | Main Index | Thread Index | Old Index