pkgsrc-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: gcc 4.8 warnings and xentools42



On Tue, Mar 25, 2014 at 06:41:25PM +0100, Martin Husemann wrote:
> That is the condition when it is set - but where is it used?

Right - it was set again, not used...

Have you any thoughts on this one?

 e1000_clear_hw_cntrs(struct e1000_hw *hw)
 {
   volatile uint32_t temp;

   temp = E1000_READ_REG(hw, CRCERRS);
   temp = E1000_READ_REG(hw, SYMERRS);
...

So, temp is never used, but it looks as though this is an attempt to
make sure the READ isn't optimised away? Safe to just get rid of the 
temp?

Cheers,

Patrick


Home | Main Index | Thread Index | Old Index