Re: [PATCH] print/ghostscript-agpl with disable-compile-inits

[Thomas Klausner <wiz%NetBSD.org@localhost>]

On Mon, Dec 23, 2013 at 06:06:02PM +0900, Makoto Fujiwara wrote:
> Hi,
> If we set 
>   PKG_OPTIONS.ghostscript+= disable-compile-inits
> we need attached patch for ghostscript-agpl-9.10.
> I've tested at print/ghostscript
> with and without following line:
>   PKG_OPTIONS.gs_type=ghostscript-gpl
> 
> gpl side, 9.05nb6 don't need this.
> May I commit this change ? commit log would be:
> -----------
> Enabling following line adds some extra files installed.
>   PKG_OPTIONS.ghostscript= disable-compile-inits
> 
> The files are listed as PLIST.disable-compile-inits
> -----------
> Thanks a lot,
> ---
> Makoto Fujiwara, 
> Chiba, Japan, Narita Airport and Disneyland prefecture.
> 
> Index: print/ghostscript-agpl/PLIST.disable-compile-inits
> ===================================================================
> RCS file: print/ghostscript-agpl/PLIST.disable-compile-inits
> diff -N print/ghostscript-agpl/PLIST.disable-compile-inits
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ print/ghostscript-agpl/PLIST.disable-compile-inits        23 Dec 2013 
> 08:49:08 -0000
> @@ -0,0 +1,6 @@
> +share/ghostscript/${PKGVERSION}/Resource/Encoding/CEEncoding
> +share/ghostscript/${PKGVERSION}/Resource/Encoding/ExpertEncoding
> +share/ghostscript/${PKGVERSION}/Resource/Encoding/ExpertSubsetEncoding
> +share/ghostscript/${PKGVERSION}/Resource/Encoding/NotDefEncoding
> +share/ghostscript/${PKGVERSION}/Resource/IdiomSet/Pscript5Idiom
> +

When making a new PLIST file, avoid empty lines please and add a 
@comment $NetBSD$
at the top, please.

> Index: print/ghostscript-agpl/options.mk
> ===================================================================
> RCS file: /cvs/cvsroot/pkgsrc/print/ghostscript-agpl/options.mk,v
> retrieving revision 1.2
> diff -u -r1.2 options.mk
> --- print/ghostscript-agpl/options.mk 22 Aug 2013 21:07:08 -0000      1.2
> +++ print/ghostscript-agpl/options.mk 23 Dec 2013 08:49:08 -0000
> @@ -54,6 +54,8 @@
>  .if !empty(PKG_OPTIONS:Mdisable-compile-inits)
>  CONFIGURE_ARGS+=     --disable-compile-inits
>  PLIST.no_cidfmap=    YES
> +PLIST_SRC+=          PLIST
> +PLIST_SRC+=          PLIST.disable-compile-inits

Why not use PLIST.foo, similar to PLIST.cidfmap?

>  .else
>  PLIST.cidfmap=               YES
>  .endif
> 

And since the PLIST is modified, please increase PKGREVISION.
 Thomas