Re: CVS commit: pkgsrc/audio/maplay

[Thomas Klausner <wiz%NetBSD.org@localhost>]

On Tue, Nov 22, 2011 at 04:37:02PM +0000, John Marino wrote:
> Module Name:  pkgsrc
> Committed By: marino
> Date:         Tue Nov 22 16:37:01 UTC 2011
> 
> Modified Files:
>       pkgsrc/audio/maplay: Makefile distinfo
>       pkgsrc/audio/maplay/patches: patch-ac patch-ah
> 
> Log Message:
> audio/maplay: Fix DragonFly breakage
> 
> This package has been broken at least since DragonFly moved to gcc44 for
> their base compiler.  The previously deprecated "-m486" is no longer
> recognized, but the -march defaults to i486 now anyway, so this switch is
> no longer required.
> 
> GCC 4.4 got rid of the iostream and iomanip backwards compatibility, so
> trying to include these headers is another source of breakage.  While
> probably correct for all platforms, this commit conservatively only
> changes the build process for DragonFly since maplay apparently is
> building okay on NetBSD.

Thank you for being so specific in your fixes!

Just for the record: It doesn't currently build on NetBSD-current, with:
===> Configuring for maplay-1.2nb1
cd /scratch/audio/maplay/work && /usr/bin/make pre-install
g++ -c -O2 -DNETBSD  maplay.cc -o maplay.o
maplay.cc:42:22: fatal error: iostream.h: No such file or directory
compilation terminated.
*** Error code 1

When I remove the ifdef around your fix, it does build. Perhaps we
should make it dependent on the compiler version; or just change it
unconditionally and require a minimum gcc version -- I guess 4.4,
based on your comment above.

Does that sound ok?
 Thomas