Re: libgphoto2 build borken (was: CVS commit: pkgsrc/devel/libgphoto2)

[Greg Oster <oster%cs.usask.ca@localhost>]

Bernd Ernesti writes:
> On Fri, Nov 14, 2008 at 06:55:32PM +0000, Chuck Cranor wrote:
> > 
> > Module Name:        pkgsrc
> > Committed By:       chuck
> > Date:               Fri Nov 14 18:55:32 UTC 2008
> > 
> > Modified Files:
> >     pkgsrc/devel/libgphoto2: Makefile distinfo
> > Added Files:
> >     pkgsrc/devel/libgphoto2/patches: patch-al
> > 
> > Log Message:
> > update to libgphoto2-2.4.3, plus pull in darwin fix for
> > camlibs/sonydscf1/sonydscf1.c from gphoto trunk
> > (u_short => unsigned short)
> 
> Hmm, it doesn't build for me on current:
> 
> creating print-camera-list
> Making all in rpm
> Making all in doc
> Making all in api
> Dummy target all-local.
> *** Error code 1
> Stop.
> make: stopped in /pkgsrc/devel/libgphoto2/work.i386/libgphoto2-2.4.3
> *** Error code 1
> 
> Trying to restart the build caused this error:
> 
> smal/ultrapocket.c: In function 'ultrapocket_command':
> smal/ultrapocket.c:65: warning: pointer targets in passing argument 2 of 'gp_
> port_write' differ in signedness
> smal/ultrapocket.c:67: warning: pointer targets in passing argument 2 of 'gp_
> port_read' differ in signedness
> smal/ultrapocket.c: In function 'ultrapocket_getrawpicture':
> smal/ultrapocket.c:236: warning: implicit declaration of function 'setlocale'
> smal/ultrapocket.c:236: error: 'LC_ALL' undeclared (first use in this functio
> n)
> smal/ultrapocket.c:236: error: (Each undeclared identifier is reported only o
> nce
> smal/ultrapocket.c:236: error: for each function it appears in.)
> smal/ultrapocket.c:236: warning: assignment makes pointer from integer withou
> t a cast
> smal/ultrapocket.c:252: warning: pointer targets in passing argument 1 of 'st
> rcpy' differ in signedness
> smal/ultrapocket.c: In function 'ultrapocket_getpicture':
> smal/ultrapocket.c:316: error: 'LC_ALL' undeclared (first use in this functio
> n)
> smal/ultrapocket.c:316: warning: assignment makes pointer from integer withou
> t a cast
> smal/ultrapocket.c:341: warning: pointer targets in passing argument 1 of 'st
> rcpy' differ in signedness
> smal/ultrapocket.c: In function 'ultrapocket_skip':   
> smal/ultrapocket.c:416: warning: pointer targets in passing argument 2 of 'gp
> _port_read' differ in signedness
> *** Error code 1
> 
> Stop.
> make: stopped in /pkgsrc/devel/libgphoto2/work.i386/libgphoto2-2.4.3/camlibs
> *** Error code 1
> 
> Bernd

ultrapocket.c needs "#include <locale.h>" added.

Later...

Greg Oster