Re: pthread_mutex_unlock

["David H. Gutteridge" <dhgutteridge%sympatico.ca@localhost>]

> I'm getting following error when running gftp:
> gftp-gtk: Error detected by libpthread: Unlocking unlocked mutex.
> Detected by file "/usr/src/lib/libpthread/pthread_mutex.c", line 369,
> function "pthread_mutex_unlock".

> I thought I could patch gftp upstream, but the code looks fine to me.

> I think this problem is known, but what is the solution ? (except
> using PTHREAD_DIAGASSERT = A).

I PRed this back in 2005, it's here:
http://www.netbsd.org/cgi-bin/query-pr-single.pl?number=31104

This isn't really something that's fair for pkgsrc to tackle, from what
I could see from the code.  (So my PR should probably be suspended or
closed.)  To second Joerg's comment, in the gtkui.c code (as of mid-
2005 anyway), the code is a bit tangled up in the sense that there can
be multiple calls of GDK_THREADS_LEAVE(), and it's not a simple matter
of changing a line or two; it appeared to me that there were multiple
potential points of entry to several code blocks that were causing the
exceptions.

I never bothered PRing it upstream, but if someone was to do so, they
might want to point out that this problem can (presumably) be
duplicated on other OSes like Linux by enabling glib2's
G_ERRORCHECK_MUTEXES macro, which makes glib2 handle these excess calls
like NetBSD does.

Regards,

Dave