Re: CVS commit: pkgsrc/sysutils/u-boot

[Roland Illig <roland.illig%gmx.de@localhost>]

On 26.05.2020 11:27, Tobias Nygren wrote:
> On Sat, 23 May 2020 09:39:06 +0000
> Roland Illig <rillig%netbsd.org@localhost> wrote:
>
> > Module Name:    pkgsrc
> > Committed By:   rillig
> > Date:           Sat May 23 09:39:06 UTC 2020
> >
> > Modified Files:
> >         pkgsrc/sysutils/u-boot: u-boot-rockchip.mk u-boot.mk
> >
> > Log Message:
> > sysutils/u-boot: remove unnecessary interpreter patches
> >
> > There was a typo in the python3 interpreter since it defined python2
> > instead of the correct python3.
> >
> > All files from the python2 block use python3 nowadays, therefore that
> > whole block is unnecessary as well.
>
> This change does not work. If the intent is really to use Python 3 then
> why does the main u-boot.mk still have:
>
> PYTHON_VERSIONS_ACCEPTED=       27

I have no idea.  I don't know how u-boot works, I just know that when
building the package, replace-interpreter was a no-op for all these files.

> Also the interpreter replacement for
> arch/arm/mach-rockchip/make_fit_atf.py was removed entirely which looks
> wrong to me.

It was a no-op. REPLACE.python2.old=python2, and the file just contains
"/usr/bin/env python", missing the "2".

> If the package needs both Python 3 and Python 2 then it was broken
> before the change too

That's what I suspect.  I'm leaving that fix to someone who actually
knows the package.

I just removed no-op code.