Re: CVS commit: pkgsrc/sysutils/u-boot

[Tobias Nygren <tnn%NetBSD.org@localhost>]

On Sat, 23 May 2020 09:39:06 +0000
Roland Illig <rillig%netbsd.org@localhost> wrote:

> Module Name:  pkgsrc
> Committed By: rillig
> Date:         Sat May 23 09:39:06 UTC 2020
> 
> Modified Files:
>       pkgsrc/sysutils/u-boot: u-boot-rockchip.mk u-boot.mk
> 
> Log Message:
> sysutils/u-boot: remove unnecessary interpreter patches
> 
> There was a typo in the python3 interpreter since it defined python2
> instead of the correct python3.
> 
> All files from the python2 block use python3 nowadays, therefore that
> whole block is unnecessary as well.

This change does not work. If the intent is really to use Python 3 then
why does the main u-boot.mk still have:

PYTHON_VERSIONS_ACCEPTED=       27

Also the interpreter replacement for
arch/arm/mach-rockchip/make_fit_atf.py was removed entirely which looks
wrong to me.

If the package needs both Python 3 and Python 2 then it was broken
before the change too, because setting

PYTHON_VERSIONS_ACCEPTED+=      37 38

in u-boot-rockchip.mk as it currently does has no effect when the main
Makefile has already committed to use 2.7. Then there should have been
a manual TOOL_DEPENDS line for lang/python37 instead.

-Tobias