Re: CVS commit: pkgsrc/databases/ldb

[Jonathan Perkin <jperkin%joyent.com@localhost>]

* On 2020-05-19 at 08:29 BST, Roland Illig wrote:

> On 19.05.2020 02:21, David H. Gutteridge wrote:
> > Module Name:        pkgsrc
> > Committed By:       gutteridge
> > Date:               Tue May 19 00:21:01 UTC 2020
> > 
> > Modified Files:
> >     pkgsrc/databases/ldb: options.mk
> > 
> > Log Message:
> > ldb: pkgsrc toolify previous (preferred sed may not be "sed")
> > 
> > 
> > -   mv ${CFG_CACHE} ${CFG_CACHE}.orig
> > -   sed -E -e 's/(ENABLE_LDAP_BACKEND =) True/\1 False/g' \
> > +   ${MV} ${CFG_CACHE} ${CFG_CACHE}.orig
> > +   ${SED} -E -e 's/(ENABLE_LDAP_BACKEND =) True/\1 False/g' \
> 
> To me, this change seems to be unnecessary. To double-check, I added the
> following lines to sysutils/checkperms/Makefile:
> 
> post-configure:
>       :; type sed
>       :; type mv
> 
> $ bmake configure
> 
> :; type sed
> sed is /home/rillig/tmp/pkgsrc.work/sysutils/checkperms/work/.tools/bin/sed
> :; type mv
> mv is /home/rillig/tmp/pkgsrc.work/sysutils/checkperms/work/.tools/bin/mv

I'm not sure I like this recommendation.  It will be significantly
slower for any commands that are wrapped rather than symlinked, which
would include something trivially builtin like ${TRUE}, and I don't
see any benefit.

-- 
Jonathan Perkin  -  Joyent, Inc.  -  www.joyent.com