Re: CVS commit: pkgsrc/databases/ldb

[Roland Illig <roland.illig%gmx.de@localhost>]

On 19.05.2020 02:21, David H. Gutteridge wrote:
> Module Name:    pkgsrc
> Committed By:   gutteridge
> Date:           Tue May 19 00:21:01 UTC 2020
>
> Modified Files:
>         pkgsrc/databases/ldb: options.mk
>
> Log Message:
> ldb: pkgsrc toolify previous (preferred sed may not be "sed")
>
>
> -       mv ${CFG_CACHE} ${CFG_CACHE}.orig
> -       sed -E -e 's/(ENABLE_LDAP_BACKEND =) True/\1 False/g' \
> +       ${MV} ${CFG_CACHE} ${CFG_CACHE}.orig
> +       ${SED} -E -e 's/(ENABLE_LDAP_BACKEND =) True/\1 False/g' \

To me, this change seems to be unnecessary. To double-check, I added the
following lines to sysutils/checkperms/Makefile:

post-configure:
        :; type sed
        :; type mv

$ bmake configure

:; type sed
sed is /home/rillig/tmp/pkgsrc.work/sysutils/checkperms/work/.tools/bin/sed
:; type mv
mv is /home/rillig/tmp/pkgsrc.work/sysutils/checkperms/work/.tools/bin/mv

The targets
{pre,do,post}-{extract,patch,configure,build,install,package} can use
the tools by their simple names.  They are taken from ${TOOLS_DIR} and
should be the preferred tools, as specified in USE_TOOLS.

While here, you could as well use the SUBST framework to do these
replacements.  If you had written both "mv" and "sed" in the same
Makefile line, pkglint would have suggested:

NOTE: options.mk:18--20: Please use the SUBST framework instead of
${SED} and ${MV}.

        Using the SUBST framework instead of explicit commands is easier to
        understand, since all the complexity of using sed and mv is hidden
        behind the scenes.

        Run "bmake help topic=subst" for more information.