Re: CVS commit: pkgsrc/lang

[Jonathan Perkin <jperkin%joyent.com@localhost>]

* On 2020-03-09 at 19:22 GMT, Adam wrote:

> >> Why do you keep insisting on making nodejs 13 use python3?  It clearly
> >> still doesn't work:
> >> 
> >> Traceback (most recent call last):
> >> File "tools/genv8constants.py", line 97, in <module>
> >>   match = pattern.match(line)
> >> TypeError: cannot use a string pattern on a bytes-like object
> >> 
> >> Please can you put my change back, and even when nodejs 13.x finally
> >> supports python3 I'd argue it should still be left that way, as it's
> >> much simpler and avoids requiring multiple versions.
> >> 
> >> Thanks,
> > 
> > Weird. It works for me. :)
> > Let me dig into that.
> > 
> > Which Python version, by the way?
> > 
> > Adam
>
> FYI: I have successfully built NodeJS 13.10.1 on
> NetBSD-current/amd64 with Python 3.6, 3.7, and 3.8.

Sorry I missed this question, though you can always find out by
viewing the bulk build reports.  The most recent is:

  https://us-east.manta.joyent.com/pkgsrc/public/reports/trunk/x86_64/20200307.1246/nodejs-13.10.1/build.log

As per the error:

  gmake[1]: *** [node_dtrace_ustack.target.mk:13: /home/pbulk/build/lang/nodejs/work/node-v13.10.1/out/Release/obj/gen/v8constants.h] Error 1

I expect this is only seen on DTrace-enabled platforms.  If I look at
the most recent macOS build:

  https://us-east.manta.joyent.com/pkgsrc/public/reports/Darwin/10.14/trunk/x86_64/20200307.1417/nodejs-13.10.1/build.log

it's currently broken for a different reason, but I'm guessing if it
got past that point in the build it would also hit the same issue as
the SmartOS build.  Prior to your change the macOS build worked fine.

-- 
Jonathan Perkin  -  Joyent, Inc.  -  www.joyent.com