pkgsrc-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: pkgsrc/lang



* On 2020-03-04 at 18:59 GMT, Adam Ciarcinski wrote:

> Module Name:  pkgsrc
> Committed By: adam
> Date:         Wed Mar  4 18:59:40 UTC 2020
> 
> Modified Files:
>       pkgsrc/lang/nodejs: Makefile Makefile.common distinfo
>       pkgsrc/lang/nodejs/patches: patch-tools_gyp_pylib_gyp_common.py
>       pkgsrc/lang/nodejs10: Makefile
>       pkgsrc/lang/nodejs12: Makefile
>       pkgsrc/lang/nodejs8: Makefile

Why do you keep insisting on making nodejs 13 use python3?  It clearly
still doesn't work:

  Traceback (most recent call last):
  File "tools/genv8constants.py", line 97, in <module>
    match = pattern.match(line)
  TypeError: cannot use a string pattern on a bytes-like object

Please can you put my change back, and even when nodejs 13.x finally
supports python3 I'd argue it should still be left that way, as it's
much simpler and avoids requiring multiple versions.

Thanks,

-- 
Jonathan Perkin  -  Joyent, Inc.  -  www.joyent.com



Home | Main Index | Thread Index | Old Index