Re: CVS commit: pkgsrc/devel/cmake

[Leonardo Taccari <leot%NetBSD.org@localhost>]

Hello Frédéric!

Frédéric Fauberteau writes:
> [...]
> Because a warning: consider to add fortran to USE_LANGUAGES. Stupid and 
> mean, I add it...
> [...]
>

Oh, okay! I think that it is checked but should work without it as
well (except - maybe - for the tests according the Makefile comments).
(This often also happens for c++ when a c++ compiler is checked in
configure but the package does not uses it)

I think it would be better to revert the USE_LANGUAGES fortran
addition in order to keep cmake dependencies and functionality as
it was.

Can you please revert it?

> Only patch-Modules_FindGTK2.cmake is related to the PR.
>
> But I have the reflex to run pkglint before committing. And I adjust 
> some things as adding fortran to USE_LANGUAGES or commenting a 
> uncommented patch...
>
> Maybe I should commit separately for this kind of cosmetics... Sorry.

Also a single commit is okay and running pkglint before commiting
change is a good habit! :)


Thank you!