Re: CVS commit: pkgsrc/devel/cmake

[Frédéric Fauberteau <triaxx%NetBSD.org@localhost>]

Hello Leonardo,

Le 2019-01-04 18:56, Leonardo Taccari a écrit :
> Hello Frédéric,
>
> Frédéric Fauberteau writes:
> > [...]
> > Index: pkgsrc/devel/cmake/Makefile
> > diff -u pkgsrc/devel/cmake/Makefile:1.156 
> > pkgsrc/devel/cmake/Makefile:1.157
> > --- pkgsrc/devel/cmake/Makefile:1.156   Sat Dec 15 23:23:14 2018
> > +++ pkgsrc/devel/cmake/Makefile Fri Jan  4 17:47:12 2019
> > @@ -1,8 +1,9 @@
> > -# $NetBSD: Makefile,v 1.156 2018/12/15 23:23:14 adam Exp $
> > +# $NetBSD: Makefile,v 1.157 2019/01/04 17:47:12 triaxx Exp $
> >
> >  .include "Makefile.version"
> >
> >  DISTNAME=      cmake-${CMAKE_VERSION}
> > +PKGREVISION=   1
> >  CATEGORIES=    devel
> >  MASTER_SITES=  https://cmake.org/files/v${CMAKE_API}/
> >
> > @@ -12,7 +13,7 @@ COMMENT=      Cross platform make
> >  LICENSE=       modified-bsd
> >
> >  USE_TOOLS+=            gmake
> > -USE_LANGUAGES=         c c++11
> > +USE_LANGUAGES=         c c++11 fortran
> >  GCC_REQD+=             4.8
> >  HAS_CONFIGURE=         yes
> >  CONFIGURE_SCRIPT=      bootstrap
> >
> > [...]
>
> Why fortran was added to USE_LANGUAGES?
>
> (It is not clear according PR pkg/53816 nor by
> <https://gitlab.kitware.com/cmake/cmake/issues/17614> but maybe I'm
> missing something!)
>
>
> Thanks!

Because a warning: consider to add fortran to USE_LANGUAGES. Stupid and 
mean, I add it...

Only patch-Modules_FindGTK2.cmake is related to the PR.

But I have the reflex to run pkglint before committing. And I adjust 
some things as adding fortran to USE_LANGUAGES or commenting a 
uncommented patch...

Maybe I should commit separately for this kind of cosmetics... Sorry.