On 02/07/2018 19:40, Pierre Pronchery wrote: > while I do not object to this change for pkgsrc-2018Q2, I was about to > mention [...] > - wip/colord, which is not up to date nor in pkgsrc Correcting myself: youri@ imported it into graphics/colord on June 13th (thanks!) I see also that print/cups should probably use DEPENDS instead of including buildlink3.mk (in the Makefile). I can change that after the freeze, and add graphics/colord there too. Cheers, -- khorben > On 02/07/2018 19:10, Greg Troxel wrote: >> Module Name: pkgsrc Committed By: gdt Date: Mon Jul 2 17:10:29 >> UTC 2018 > >> Modified Files: pkgsrc/x11/gtk3: options.mk > >> Log Message: gtk3: drop cups from SUGGESTED_OPTIONS > >> cups was added as default recently without broad discussion. pkgsrc >> has long declined to endorse/require a particular approach to >> printing (because of the multitude of strong opinions about >> printing). Defaulting to cups requires that everyone install it, >> and some object. In addition, cups does not build on macos, >> resulting in all packages depending on gtk3 being broken. The >> cups option is not enabled by default on other packages. It seems >> that this option is not necessary for programs using gtk3 to print >> on a cups-using system. > >> I'm reverting this as the freeze coordinator so that 2018Q2 has the >> longstanding behavior. Longer term, the question of whether cups >> should be a default option bears discussion, including about what >> the cosequences are for those who do and don't use cups, whether it >> should be per-package or global, and about whether we want to >> deviate on systems that can't build cups. (Note that we are only >> talking about the defaults and binary packages built using the >> defaults; it's long been possible for anyone to enable the cups >> options globally for their own builds.) > > >> To generate a diff of this commit: cvs rdiff -u -r1.12 -r1.13 >> pkgsrc/x11/gtk3/options.mk > >> Please note that diffs are not public domain; they are subject to >> the copyright notices on the relevant files. > > > >> Modified files: > >> Index: pkgsrc/x11/gtk3/options.mk diff -u >> pkgsrc/x11/gtk3/options.mk:1.12 pkgsrc/x11/gtk3/options.mk:1.13 >> --- pkgsrc/x11/gtk3/options.mk:1.12 Mon Jun 11 23:44:15 2018 +++ >> pkgsrc/x11/gtk3/options.mk Mon Jul 2 17:10:29 2018 @@ -1,4 +1,4 @@ >> -# $NetBSD: options.mk,v 1.12 2018/06/11 23:44:15 youri Exp $ +# >> $NetBSD: options.mk,v 1.13 2018/07/02 17:10:29 gdt Exp $ > >> PKG_OPTIONS_VAR= PKG_OPTIONS.gtk3 PKG_SUPPORTED_OPTIONS= >> gtk3-atk-bridge cups debug @@ -7,7 +7,7 @@ >> PKG_OPTIONS_GROUP.gdk-target= x11 .if >> exists(/System/Library/Frameworks/Quartz.framework) >> PKG_OPTIONS_GROUP.gdk-target+= quartz .endif >> -PKG_SUGGESTED_OPTIONS= gtk3-atk-bridge x11 cups >> +PKG_SUGGESTED_OPTIONS= gtk3-atk-bridge x11 > >> .include "../../mk/bsd.options.mk" > > > > > -- khorben
Attachment:
signature.asc
Description: OpenPGP digital signature