Re: CVS commit: pkgsrc/editors/emacs20

[David Holland <dholland-pkgchanges%netbsd.org@localhost>]

On Sun, Jul 07, 2013 at 01:59:29AM +0900, Ryo ONODERA wrote:
 > >  > This test case is for gcc -E -traditional-cpp detection.
 > >  > I want to disable this detection, so it is not the best way,
 > >  > it is ugly, but making the test one line is easiest way of disabling
 > >  > -traditional-cpp detection.
 > > 
 > > The logic there was intentionally patched in; if you think it should
 > > go away, it should be removed entirely rather than being neutered.
 > > 
 > > However, I don't think it should go away: probing for a cpp that will
 > > work fixed the build on a number of platforms and until the tools
 > > wrappers are prepared to provide transparent support for "gcc -E
 > > -traditional-cpp", which they aren't, this logic is still needed.
 > 
 > I see. But I have no motivation for supporting such old emacsen.
 > Please improve it freely.

Well, I'm just trying to keep you from breaking it :-)

 > > What's the build problem? I build it routinely with X support (and one
 > > of these days I'm going to bring back emacs20-nox11 to reduce the
 > > number of special cases in the emacs infrastructure) and I haven't had
 > > trouble, but I haven't pulled the absolute latest X updates yet.
 > > 
 > > There isn't anywhere I can see in the makefiles that it uses the cpp
 > > it probes on source files, except for one case involving alloca that
 > > shouldn't affect netbsd (and that might or might not use the probed
 > > cpp anyway...) so I wonder if you're running into some other problem.
 > 
 > 
 > With emacs 21 and emacs20 with x11 option,
 > gcc -E -traditional-cpp and 6.99.23's native X generates
 > the following error to config.log.

Well... that line in Xfuncproto.h is also there in the version I have
(6.99.19), with the same guard conditions, and the build (without your
change) works fine, just as it has all along.

What compiler are you using?

-- 
David A. Holland
dholland%netbsd.org@localhost