Re: CVS commit: pkgsrc/editors/emacs20

[David Holland <dholland-pkgchanges%netbsd.org@localhost>]

On Sat, Jul 06, 2013 at 01:36:26PM +0900, Ryo ONODERA wrote:
 > > On Fri, Jul 05, 2013 at 01:46:13PM +0000, Ryo ONODERA wrote:
 > >  > Modified Files:
 > >  >         pkgsrc/editors/emacs20: distinfo
 > >  >         pkgsrc/editors/emacs20/patches: patch-ab
 > >  > 
 > >  > Log Message:
 > >  > Fix x11 option build.
 > > 
 > > @@ -72,8 +72,7 @@
 > >   #include "confdefs.h"
 > >   #include <assert.h>
 > >   Syntax Error
 > > -+Should \\
 > > -+be one line.
 > > ++Should be one line.
 > >   EOF
 > > 
 > > I don't think you wanted that... what were you trying to do?
 > 
 > This test case is for gcc -E -traditional-cpp detection.
 > I want to disable this detection, so it is not the best way,
 > it is ugly, but making the test one line is easiest way of disabling
 > -traditional-cpp detection.

The logic there was intentionally patched in; if you think it should
go away, it should be removed entirely rather than being neutered.

However, I don't think it should go away: probing for a cpp that will
work fixed the build on a number of platforms and until the tools
wrappers are prepared to provide transparent support for "gcc -E
-traditional-cpp", which they aren't, this logic is still needed.

What's the build problem? I build it routinely with X support (and one
of these days I'm going to bring back emacs20-nox11 to reduce the
number of special cases in the emacs infrastructure) and I haven't had
trouble, but I haven't pulled the absolute latest X updates yet.

There isn't anywhere I can see in the makefiles that it uses the cpp
it probes on source files, except for one case involving alloca that
shouldn't affect netbsd (and that might or might not use the probed
cpp anyway...) so I wonder if you're running into some other problem.

-- 
David A. Holland
dholland%netbsd.org@localhost