Re: CVS commit: pkgsrc/mk

[Matthias Scheler <tron%netbsd.org@localhost>]

On Wed, Jun 05, 2013 at 12:19:30PM +0100, David Brownlee wrote:
> > Log Message:
> > Revert change to "PKG_SETENV":
> > 1.) It breaks the build of "www/firefox" which gets upset if "SHELL" is
> >     not defined in the environment. There are probably more packages
> >     which similar problems.
> 
> I built quite a large chunk of pkgsrc including kde4 and firefox was
> the only package I've hit which failed to build. Can anyone think of
> any reason why SHELL should not be added to ALL_ENV?

I can't see a reason. Just didn't know how to fix this properly.

> > 2.) It breaks established use case like this one:
> >
> >         export ALLOW_VULNERABLE_PACKAGES=yes
> >         cd pkgsrc/multimedia/ffmpeg2theora
> >         bmake install
> >
> >     In this case the value of "ALLOW_VULNERABLE_PACKAGES" will not be
> >     passed to the build of "pkgsrc/multimedia/ffmpeg". And the build of
> >     this package will fail due to known vulnerabilities.
> 
> I think that if there is a list of well defined environment values
> which are expected to be viable to pass into a build then they should
> be documented, and explicitly added to ALL_ENV - whether or not we are
> using SETENV=env -i

That sounds like a good approach. But based on Greg's objection I'm not
going to commit that right now.

        Kind regards

-- 
Matthias Scheler                                  http://zhadum.org.uk/