Re: CVS commit: pkgsrc/mk

[David Brownlee <abs%netbsd.org@localhost>]

On 5 June 2013 09:19, Matthias Scheler <tron%netbsd.org@localhost> wrote:
> Module Name:    pkgsrc
> Committed By:   tron
> Date:           Wed Jun  5 08:19:57 UTC 2013
>
> Modified Files:
>         pkgsrc/mk: bsd.pkg.mk
>
> Log Message:
> Revert change to "PKG_SETENV":
> 1.) It breaks the build of "www/firefox" which gets upset if "SHELL" is
>     not defined in the environment. There are probably more packages
>     which similar problems.

I built quite a large chunk of pkgsrc including kde4 and firefox was
the only package I've hit which failed to build. Can anyone think of
any reason why SHELL should not be added to ALL_ENV?

> 2.) It breaks established use case like this one:
>
>         export ALLOW_VULNERABLE_PACKAGES=yes
>         cd pkgsrc/multimedia/ffmpeg2theora
>         bmake install
>
>     In this case the value of "ALLOW_VULNERABLE_PACKAGES" will not be
>     passed to the build of "pkgsrc/multimedia/ffmpeg". And the build of
>     this package will fail due to known vulnerabilities.

I think that if there is a list of well defined environment values
which are expected to be viable to pass into a build then they should
be documented, and explicitly added to ALL_ENV - whether or not we are
using SETENV=env -i

That would also include a well documented way to pass arbitrary
values, though that may well be a PASS_ALL_ENV=yes