Re: CVS commit: pkgsrc/devel/cmph

[Aleksej Saushev <asau%inbox.ru@localhost>]

John Marino <netbsd%marino.st@localhost> writes:

> On 10/12/2012 19:04, Aleksej Saushev wrote:
>> John Marino<netbsd%marino.st@localhost>  writes:
>>> Also, those are all of the -Werror type of problems barring the
>>> last 800 packages I'm running now.  I'm finished fixing this
>>> type.
>>
>> There may be lots of other significant warnings that do point to problems,
>> and those warnings are exactly the reason why -Werror exists and turned on.
>
> Okay, let me get this straight.
> This Werror was set FOR YEARS and didn't come up with any
> problems on existing compilers.  You seem to be saying that by
> turning it off now, suddenly new problems will magically appear
> that affects all these GCC 3.0 - 4.4 systems fatally (or
> insidiously).

Yes, these are new problems, and they must be attributed to compilers.
Yes, it is possible for them to affect all systems fatally, even those
using older compilers.

"-Werror" didn't appear out of blue, there're reasons why the flag
exists at all. Same reasons apply to existence of compiler warnings.
It is possible not to include any diagnostics into compiler. I wonder
why people care of those pesky warning messages and their clarity at all.
Just imagine how life would be easier if all package would build!
It doesn't matter that some of them wouldn't run because they can't find
needed library or they don't contain all files they need. All of them
would build instead!

> Obviously that's nonsense, so then you must mean compilers newer
> than 4.7, which you said NetBSD wouldn't have anyway.
>
> Do you have a realistic case here?  Because this just seems argumentative.
>
> Are you in favor of grepping all makefiles and patches to see
> what packages are removing -Werror and reworking them?  Because
> that is the logical conclusion to your stance.

Yes, exactly. Packages should build with -Werror set, if they supported it.
Those that don't build should be fixed rather than their problems swept
under the rug. Removing -Werror may only be a temporary measure, a hack,
it is not a solution in any case.


-- 
HE CE3OH...