Re: CVS commit: pkgsrc/devel/cmph

[Alistair Crooks <agc%pkgsrc.org@localhost>]

On Fri, Oct 12, 2012 at 08:01:00AM +0000, John Marino wrote:
> Module Name:  pkgsrc
> Committed By: marino
> Date:         Fri Oct 12 08:01:00 UTC 2012
> 
> Modified Files:
>       pkgsrc/devel/cmph: Makefile
> 
> Log Message:
> devel/cmph: Fix build for gcc 4.6+
> 
> Remove -Werror (catches -Wunused-but-set-variable) to fix build.

Please stop doing this (removing -Werror) now - it is not fixing
anything, and will make things harder in future to spot problems.

More acceptable ways to fix these kind of things:

1. check if there's a new version out which might have fixes for this

2. fix the problem, not the reporter of the problem

3. mark the package as broken on your platform

4. if you can't do any of these, then let someone else deal with it

Thanks,
Alistair