pkgsrc-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: pkgsrc/cross/mingw-binutils

On 10/12/2012 00:57, Aleksej Saushev wrote:
John Marino<>  writes:

A) I don't think it's a hack to turn this off
B) There may not be a choice barring the patching off source.
If -Werror is applied after CFLAGS, it's impossible to disable
from the makefile.

Instead of letting package fail when it might be in danger of losing its
functionality, you let it build with potential errors. Thus it is a hack.

Here's my issue with that stance:
Let's say the source is 7 years old. The same potential problem was there the entire time, but no compiler detected it as a warning. Now one does. If it's really a problem, the problem was always there and nobody noticed. And masking -Werror doesn't delete the new warning, it still shows up in the log. So you've only gained, not lost, by masking it.

I don't see why -Werror should be for debug versions. It doesn't affect
run time but it makes sure that released package doesn't contain code
of certain (inferior) quality.

Same comment as above.

Home | Main Index | Thread Index | Old Index