pkg/59250: lang/gcc12 fails to build on Darwin

[triaxx%netbsd.org@localhost]

>Number:         59250
>Category:       pkg
>Synopsis:       lang/gcc12 fails to build on Darwin
>Confidential:   no
>Severity:       critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Apr 03 20:10:00 +0000 2025
>Originator:     Frédéric Fauberteau
>Release:        Darwin 24.3.0
>Organization:
>Environment:
System: Darwin MBCMW40CH6R6 24.3.0 Darwin Kernel Version 24.3.0: Thu Jan  2 20:23:36 PST 2025; root:xnu-11215.81.4~3/RELEASE_ARM64_T8112 arm64
Architecture: arm64
Machine: aarch64
Pkgsrc: HEAD (20250303)
SDK Version: 15.4
>Description:
The build step fails with the following error message:

checking stack direction for C alloca... In file included from ../../gcc-12.4.0/zlib/zutil.c:10:                                                                                                                                                                                
In file included from ../../gcc-12.4.0/zlib/gzguts.h:21:                                                                                                                                                                                                                        
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/stdio.h:61:                                                                                                                                                                               
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/_stdio.h:316:7: error: expected identifier or '('                                                                                                                                                               
  316 | FILE    *fdopen(int, const char *) __DARWIN_ALIAS_STARTING(__MAC_10_6, __IPHONE_3_2, __DARWIN_EXTSN(fdopen));                                                                                                                                                           
      |          ^                                                                                                                                                                                                                                                              
../../gcc-12.4.0/zlib/zutil.h:140:33: note: expanded from macro 'fdopen'                                                                                                                                                                                                        
  140 | #        define fdopen(fd,mode) NULL /* No fdopen() */                                                                                                                                                                                                                  
      |                                 ^                 
>How-To-Repeat:
cd lang/gcc12 && bmake build
>Fix:
--- zutil.c.orig        2025-04-03 21:41:20
+++ zutil.c     2025-04-03 21:41:29
@@ -5,10 +5,10 @@
 
 /* @(#) $Id: zutil.c,v 1.1.1.2 2002/03/11 21:53:27 tromey Exp $ */
 
-#include "zutil.h"
	
 #ifndef Z_SOLO
 #  include "gzguts.h"
 #endif
+#include "zutil.h"
 
 z_const char * const z_errmsg[10] = {
     (z_const char *)"need dictionary",     /* Z_NEED_DICT       2  */