pkg/51604: x11/xfce4-tumbler PLIST_VARS aren't actually used in PLIST

[davshao%gmail.com@localhost]

>Number:         51604
>Category:       pkg
>Synopsis:       x11/xfce4-tumbler PLIST_VARS aren't actually used in PLIST
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Nov 06 04:55:00 +0000 2016
>Originator:     David Shao
>Release:        current pkgsrc
>Organization:
>Environment:
DragonFly  4.7-DEVELOPMENT DragonFly v4.7.0.777.g55bcc-DEVELOPMENT #2: Sat Nov  5 19:57:01 PDT 2016     xxxxxx@:/usr/obj/usr/src/sys/X86_64_GENERIC  x86_64

>Description:
For current pkgsrc x11/xfce4-tumbler, some effort has been made to give in options.mk an option to not build with say multimedia/ffmpegthumbnailer.  Unfortunately the PLIST_VARS defined in options.mk are not actually used in PLIST, so that

bmake install package

fails on for example DragonFly 4.7-DEVELOPMENT with the line

PKG_OPTIONS.tumbler= -ffmpegthumbnailer

added to /usr/pkg/etc/mk.conf


>How-To-Repeat:

>Fix:
If only dealing with ffmpegthumbnailer, the following patch allows

bmake install package clean

to work on DragonFly 4.7-DEVELOPMENT; however, the other PLIST_VARS from options.mk might need to be used in PLIST as well.

diff -Nur x11/xfce4-tumbler/PLIST x11/xfce4-tumbler.new/PLIST
--- x11/xfce4-tumbler/PLIST	2015-04-21 01:56:45.000000000 -0700
+++ x11/xfce4-tumbler.new/PLIST	2016-11-05 21:34:25.601370000 -0700
@@ -21,7 +21,7 @@
 lib/tumbler-1/plugins/cache/tumbler-cache-plugin.so
 lib/tumbler-1/plugins/cache/tumbler-xdg-cache.la
 lib/tumbler-1/plugins/tumbler-cover-thumbnailer.la
-lib/tumbler-1/plugins/tumbler-ffmpeg-thumbnailer.la
+${PLIST.ffmpegthumbnailer}lib/tumbler-1/plugins/tumbler-ffmpeg-thumbnailer.la
 lib/tumbler-1/plugins/tumbler-font-thumbnailer.la
 lib/tumbler-1/plugins/tumbler-jpeg-thumbnailer.la
 lib/tumbler-1/plugins/tumbler-odf-thumbnailer.la