Re: pkg/48974: textproc/mdocml does not build on Solaris 10

[Joerg Sonnenberger <joerg%britannica.bec.de@localhost>]

The following reply was made to PR pkg/48974; it has been noted by GNATS.

From: Joerg Sonnenberger <joerg%britannica.bec.de@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: pkg-manager%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, 
pkgsrc-bugs%netbsd.org@localhost,
        joern.clausen%uni-bielefeld.de@localhost
Subject: Re: pkg/48974: textproc/mdocml does not build on Solaris 10
Date: Wed, 9 Jul 2014 16:38:31 +0200

 On Wed, Jul 09, 2014 at 02:00:01PM +0000, Jörn Clausen wrote:
 >  >   Try adding FEATURE_LIBS to the mandoc link line instead.
 >  
 >  Do you mean like this:
 >  
 >    mandoc: $(MANDOC_OBJS) libmandoc.a
 >  -       $(CC) $(LDFLAGS) -o $@ $(MANDOC_OBJS) libmandoc.a
 >  +       $(CC) $(LDFLAGS) -o $@ $(MANDOC_OBJS) libmandoc.a $(FEATURE_LIBS)
 
 Yeah.
 
 >  That does not work:
 >  
 >  gcc -L/pkgsrc/source/pkgsrc/textproc/mdocml/work.pkgsrc-i86/libnbcompat 
 >  -L/usr/pkgsrc/20140707/lib -Wl,-R/usr/pkgsrc/20140707/lib -L/usr/lib 
 >  -Wl,-R/usr/lib -o mandoc eqn_html.o  html.o  man_html.o  mdoc_html.o 
 >  tbl_html.o  mdoc_man.o  eqn_term.o  man_term.o  mdoc_term.o  term.o 
 >  term_ascii.o  term_ps.o  tbl_term.o  main.o  out.o  tree.o libmandoc.a
 >  Undefined                       first referenced
 >    symbol                             in file
 >  asprintf                            libmandoc.a(mdoc.o)
 
 OIC It's not exported, e.g. ALL_ENV+= FEATURE_LIBS=${FEATURE_LIBS:Q} is
 also needed.
 
 >  Even if it would work: Is it a good idea to replace all the functions 
 >  defined in libnbcompat, even those provided by the OS?
 
 Existing and not-known-to-be-broken functions shouldn't be defined in
 libnbcompat.a.
 
 Joerg