Re: PR/48134 CVS commit: pkgsrc/security/crypto++

[Ryo ONODERA <ryo_on%yk.rim.or.jp@localhost>]

The following reply was made to PR pkg/48134; it has been noted by GNATS.

From: Ryo ONODERA <ryo_on%yk.rim.or.jp@localhost>
To: gnats-bugs%NetBSD.org@localhost, o.vd.linden%quicknet.nl@localhost
Cc: 
Subject: Re: PR/48134 CVS commit: pkgsrc/security/crypto++
Date: Sat, 24 Aug 2013 15:55:09 +0900 (JST)

 Hi,
 
 From: Onno van der Linden <o.vd.linden%quicknet.nl@localhost>, Date: Thu, 22 
Aug 2013 18:15:01 +0000 (UTC)
 
 >  With the fix above crypto++ compiles out of the box.
 >  Trying to compile net/amule with this crypto++:
 >  
 >  amule-ClientCreditsList.o: In function 
 > `CClientCreditsList::CreateKeyPair()':
 >  ClientCreditsList.cpp:(.text+0x21c3): undefined reference to 
 > `CryptoPP::AlignedDeallocate(void*)'
 >  amule-ClientCreditsList.o: In function `CryptoPP::Integer::~Integer()':
 >  
 > ClientCreditsList.cpp:(.text._ZN8CryptoPP7IntegerD2Ev[_ZN8CryptoPP7IntegerD5Ev]+0x2c):
 >  undefined reference to `CryptoPP::AlignedDeallocate(void*)'
 >  
 >  With the appended fix in crypto++/patches/patch-ab I did
 >  a make distinfo and a reinstall of crypto++ after which
 >  net/amule also could be compiled, linked and installed
 >  
 >  Onno
 >  
 >  --- config.h.orig   2013-08-22 19:02:33.000000000 +0200
 >  +++ config.h        2013-08-22 19:04:24.000000000 +0200
 >  @@ -290,12 +290,6 @@
 >      #define CRYPTOPP_BOOL_AESNI_INTRINSICS_AVAILABLE 0
 >   #endif
 >   
 >  -#if CRYPTOPP_BOOL_SSE2_INTRINSICS_AVAILABLE || 
 > CRYPTOPP_BOOL_SSE2_ASM_AVAILABLE || defined(CRYPTOPP_X64_MASM_AVAILABLE)
 >  -   #define CRYPTOPP_BOOL_ALIGN16_ENABLED 1
 >  -#else
 >  -   #define CRYPTOPP_BOOL_ALIGN16_ENABLED 0
 >  -#endif
 >  -
 >   // how to allocate 16-byte aligned memory (for SSE2)
 >   #if defined(CRYPTOPP_MSVC6PP_OR_LATER)
 >      #define CRYPTOPP_MM_MALLOC_AVAILABLE
 >  @@ -307,6 +301,13 @@
 >      #define CRYPTOPP_NO_ALIGNED_ALLOC
 >   #endif
 >   
 >  +#if CRYPTOPP_BOOL_SSE2_INTRINSICS_AVAILABLE || 
 > CRYPTOPP_BOOL_SSE2_ASM_AVAILABLE || defined(CRYPTOPP_X64_MASM_AVAILABLE) || 
 > !defined(CPRYPTO_NO_ALIGNED_ALLOC)
 >  +   #define CRYPTOPP_BOOL_ALIGN16_ENABLED 1
 >  +#else
 >  +   #define CRYPTOPP_BOOL_ALIGN16_ENABLED 0
 >  +#endif
 >  +
 >  +
 >   // how to disable inlining
 >   #if defined(_MSC_VER) && _MSC_VER >= 1300
 >   #  define CRYPTOPP_NOINLINE_DOTDOTDOT
 
 What is the meaning of moving definition to later location?
 It seems that simply adding || !defined(CPRYPTO_NO_ALIGNED_ALLOC) is
 sufficient for me, and works with amule.
 
 --
 Ryo ONODERA // ryo_on%yk.rim.or.jp@localhost
 PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3