Re: PR/48134 CVS commit: pkgsrc/security/crypto++

[Onno van der Linden <o.vd.linden%quicknet.nl@localhost>]

The following reply was made to PR pkg/48134; it has been noted by GNATS.

From: Onno van der Linden <o.vd.linden%quicknet.nl@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: PR/48134 CVS commit: pkgsrc/security/crypto++
Date: Thu, 22 Aug 2013 20:11:03 +0200

 On Thu, Aug 22, 2013 at 01:20:01PM +0000, Ryo ONODERA wrote:
 > The following reply was made to PR pkg/48134; it has been noted by GNATS.
 > 
 > From: "Ryo ONODERA" <ryoon%netbsd.org@localhost>
 > To: gnats-bugs%gnats.NetBSD.org@localhost
 > Cc: 
 > Subject: PR/48134 CVS commit: pkgsrc/security/crypto++
 > Date: Thu, 22 Aug 2013 13:15:05 +0000
 > 
 >  Module Name:        pkgsrc
 >  Committed By:       ryoon
 >  Date:               Thu Aug 22 13:15:05 UTC 2013
 >  
 >  Modified Files:
 >      pkgsrc/security/crypto++: Makefile distinfo
 >      pkgsrc/security/crypto++/patches: patch-aa
 >  
 >  Log Message:
 >  Bump PKGREVISION.
 >  
 >  Remove -march=native for portable binary.
 >  For PR pkg/48134.
 >  Thank you, joerg@.
 
 With the fix above crypto++ compiles out of the box.
 Trying to compile net/amule with this crypto++:
 
 amule-ClientCreditsList.o: In function `CClientCreditsList::CreateKeyPair()':
 ClientCreditsList.cpp:(.text+0x21c3): undefined reference to 
`CryptoPP::AlignedDeallocate(void*)'
 amule-ClientCreditsList.o: In function `CryptoPP::Integer::~Integer()':
 
ClientCreditsList.cpp:(.text._ZN8CryptoPP7IntegerD2Ev[_ZN8CryptoPP7IntegerD5Ev]+0x2c):
 undefined reference to `CryptoPP::AlignedDeallocate(void*)'
 
 With the appended fix in crypto++/patches/patch-ab I did
 a make distinfo and a reinstall of crypto++ after which
 net/amule also could be compiled, linked and installed
 
 Onno
 
 --- config.h.orig      2013-08-22 19:02:33.000000000 +0200
 +++ config.h   2013-08-22 19:04:24.000000000 +0200
 @@ -290,12 +290,6 @@
        #define CRYPTOPP_BOOL_AESNI_INTRINSICS_AVAILABLE 0
  #endif
  
 -#if CRYPTOPP_BOOL_SSE2_INTRINSICS_AVAILABLE || 
CRYPTOPP_BOOL_SSE2_ASM_AVAILABLE || defined(CRYPTOPP_X64_MASM_AVAILABLE)
 -      #define CRYPTOPP_BOOL_ALIGN16_ENABLED 1
 -#else
 -      #define CRYPTOPP_BOOL_ALIGN16_ENABLED 0
 -#endif
 -
  // how to allocate 16-byte aligned memory (for SSE2)
  #if defined(CRYPTOPP_MSVC6PP_OR_LATER)
        #define CRYPTOPP_MM_MALLOC_AVAILABLE
 @@ -307,6 +301,13 @@
        #define CRYPTOPP_NO_ALIGNED_ALLOC
  #endif
  
 +#if CRYPTOPP_BOOL_SSE2_INTRINSICS_AVAILABLE || 
CRYPTOPP_BOOL_SSE2_ASM_AVAILABLE || defined(CRYPTOPP_X64_MASM_AVAILABLE) || 
!defined(CPRYPTO_NO_ALIGNED_ALLOC)
 +      #define CRYPTOPP_BOOL_ALIGN16_ENABLED 1
 +#else
 +      #define CRYPTOPP_BOOL_ALIGN16_ENABLED 0
 +#endif
 +
 +
  // how to disable inlining
  #if defined(_MSC_VER) && _MSC_VER >= 1300
  #     define CRYPTOPP_NOINLINE_DOTDOTDOT